Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: [Android Specific] Splash screen appears when confirmation resign bottom sheets are triggered #13870

Closed
cortisiko opened this issue Mar 6, 2025 · 1 comment · Fixed by #13927, #13926 or #13914
Closed

[Bug]: [Android Specific] Splash screen appears when confirmation resign bottom sheets are triggered #13870

cortisiko opened this issue Mar 6, 2025 · 1 comment · Fixed by #13927, #13926 or #13914
Assignees
@digiwand
Labels
android Android specific issue regression-RC-7.42.0 Regression bug that was found in release candidate (RC) for release 7.42.0 release-blocker This bug is blocking the next release Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@cortisiko
Copy link
Member

Describe the bug

Every time the confirmation redesign signature bottom sheet is triggered, the MetaMask splash screen appears behind the bottom sheet. The expected behavior is for the dapp in the browser to remain visible behind the bottom sheet.

This behavior does not exist on current production.

See the below image for what the MetaMask splash screen looks like.
Image

Expected behavior

The expected behavior is for the dapp in the browser to remain visible behind the bottom sheet.

Screenshots/Recordings

Current prod: 7.41.0

confirmation-redesign7.41.mp4

RC Build: 7.42.0

confirmations-redesign-bugv7.42.0.mp4

Steps to reproduce

Launch the android app
Go to the metamask test dapp
Scroll to one of the signature dapp interactions
tap sign

notice:

  • the browser disappears,
  • the splash screen behavior
  • and the signature bottom sheet appears

Error messages or log output



Detection stage


During release testing


Version


7.42.0 RC1 (1587)


Build type


None


Device


All Android devices


Operating system


Android


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @cortisiko
cortisiko




            added
      

  regression-RC-7.42.0

  Regression bug that was found in release candidate (RC) for release 7.42.0

      

  Sev2-normal

  An issue that may lead to users misunderstanding some limited risks they are taking

      

  team-confirmations-secure-ux-PR

  PR from the confirmations team

      

  type-bug

  Something isn't working

  labels


      Mar 6, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be triaged
  in Bugs by team


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @cortisiko
cortisiko




          added
  the 

  android

  Android specific issue
 label


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @sleepytanya
sleepytanya




          added
  the 

  team-confirmations

  Push issues to confirmations team
 label


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @digiwand
digiwand




              self-assigned this


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @matthewwalsh0
matthewwalsh0




            added
      

  release-blocker

  This bug is blocking the next release

    and removed
      

  team-confirmations-secure-ux-PR

  PR from the confirmations team

  labels


      Mar 6, 2025

    

  



  

  

    
  


  

      

    @digiwand
digiwand



    mentioned this issue
    
      Mar 7, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  OGPoyraz 

      pushed a commit
      that referenced
      this issue

    
      Mar 7, 2025
    
    

      


  

    

      


  

      
        @digiwand
      
        @brianacnguyen
  





      

        
          fix: cherry-pick 7.42.0 refactor: Replace redesign confirmation Botto…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          dcf5047
        
      

    

  

    

      
…mModal with BottomSheet (#13914)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Cherry-picks 1/3 BottomSheet fix:
#13268 into 7.42.0

Todo cherry-picks:
2/3: #13783
3/3: #13913

## **Related issues**

Fixes: #13870

## **Manual testing steps**

Open any redesign signature in Android to test related bug fix

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Brian Nguyen <brianacnguyen@gmail.com>

    




    

  




  

  

    
  


  

      

  This was referenced Mar 7, 2025





  


  

      
   Merged

  






      






  


  

      
   Merged

  






  




  


  
    
  
  

    
  OGPoyraz 

      pushed a commit
      that referenced
      this issue

    
      Mar 7, 2025
    
    

      


  

    

      


  

      
        @digiwand
  





      

        
          fix: [cherry-pick | 7.42.0] Confirm Scroll and close on swipe down an…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          8a2ebd1
        
      

    

  

    

      
…d backdrop click (#13927)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Cherry-picks 3/3 BottomSheet fix
#13913 into 7.42.0

## **Related issues**

Fixes: #13870

Cherry-pick PRs:
1/3: #13914 (BottomModal
→ BottomSheet)
2/3: #13926 (bitrise
failure testID)
3/3: #13927 (scroll and
close on swipe down & backdrop click)

## **Manual testing steps**

Test redesign confirmation page behavior

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




  

  

    
  


  

    


    This was
    linked to
    pull requests
    Mar 7, 2025





  

    
      fix: [cherry-pick | 7.42.0] Confirm Scroll and close on swipe down and backdrop click
      #13927
  



  

      
   Merged

  






    







  

    
      fix: [cherry-pick | 7.42.0] bitrise missing signature elements following BottomModal → Botto…
      #13926
  



  

      
   Merged

  






    







  

    
      fix: [cherry-pick | 7.42.0] refactor: Replace redesign confirmation BottomModal with BottomSheet
      #13914
  



  

      
   Merged

  






  









      

  
      



  

  @cortisiko





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

  





      


        


  
    

      
          
Confirming that this bug was fixed and no longer an issue on v7.42.0 RC2

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Mar 7, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @digiwand
  
    digiwand
    

      








      


  


  

    Labels
  



    

      

    android

  Android specific issue
  

    regression-RC-7.42.0

  Regression bug that was found in release candidate (RC) for release 7.42.0
  

    release-blocker

  This bug is blocking the next release
  

    Sev2-normal

  An issue that may lead to users misunderstanding some limited risks they are taking
  

    team-confirmations

  Push issues to confirmations team
  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: To be triaged

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
  




      

    

  
      

  

    

      4 participants
    

    

        
          @cortisiko 
        
          @matthewwalsh0 
        
          @digiwand 
        
          @sleepytanya