Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [iOS specific] Network select bottom disappears while searching for a network #13781

Closed
cortisiko opened this issue Feb 28, 2025 · 0 comments · Fixed by #13810
Closed
Assignees
Labels
regression-prod-7.40 Regression bug that was found in production in release 7.40 release-7.43.0 Issue or pull request that will be included in release 7.43.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@cortisiko
Copy link
Member

Describe the bug

The network select bottom sheet disappears while I search for a network name. This is terrible UX, as it seems like our UI is buggy.

Expected behavior

Network search should not result in the bottom sheet disappearing

Screenshots/Recordings

ScreenRecording_02-28-2025.18-04-03_1.mov

Steps to reproduce

When I am on the wallet view
And I tap on the network picker
And I search for a network name
Then the network select bottom sheet disappears.

Error messages or log output

Detection stage

In production (default)

Version

7.41.0 (1586)

Build type

None

Device

iOS and Android

Operating system

Other (please elaborate in the "Additional Context" section)

Additional context

No response

Severity

No response

@cortisiko cortisiko added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working labels Feb 28, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 28, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 28, 2025
@sleepytanya sleepytanya added the regression-prod-7.40 Regression bug that was found in production in release 7.40 label Mar 1, 2025
@cortisiko cortisiko changed the title [Bug]: Network select bottom disappears while search a network [Bug]: [iOS specific] Network select bottom disappears while search a network Mar 3, 2025
@Prithpal-Sooriya Prithpal-Sooriya self-assigned this Mar 3, 2025
@cortisiko cortisiko changed the title [Bug]: [iOS specific] Network select bottom disappears while search a network [Bug]: [iOS specific] Network select bottom disappears while searching for a network Mar 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2025
…13810)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This is an IOS specific issue where the content goes behind the virtual
keyboard and is hidden if it is too small.

## **Related issues**

Fixes: #13781

## **Manual testing steps**

1. Go to network selector modal
2. Filter the list to 1 item (e.g. Ethereum)
3. EXPECTED - ensure that the content is still visible on an IOS device
with the keyboard open.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://www.loom.com/share/7013a5cd960849ffaa4d3cbaf2456a17?sid=58523d20-2bfb-474d-ac45-284f572df4f1

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be triaged to Ready to be fixed in Bugs by team Mar 5, 2025
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.40 Regression bug that was found in production in release 7.40 release-7.43.0 Issue or pull request that will be included in release 7.43.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Archived in project
Status: Ready to be fixed
Development

Successfully merging a pull request may close this issue.

4 participants