-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: Multichain workflow in smoke pipeline is a bit unstable #12872
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The purpose of this PR is to disable a couple of chain permission tests that are flaking as of recently. We aim to renable these tests in #12872 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
salimtb
pushed a commit
that referenced
this issue
Jan 9, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The purpose of this PR is to disable a couple of chain permission tests that are flaking as of recently. We aim to renable these tests in #12872 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
The multichain workflows for iOS and Android have become unstable recently. One of the main culprits is the existence of the toast notification. Sometimes, the toast notification blocks a particular UI the test cannot interact with, resulting in failures. Depending on the time of day bitrise might play nice and the toast disappears in a timely fashion. This is not ideal, as it could lead to false positives. We should modify the tests better to handle the appearance of the toast(s).
Here is a video recording showcasing the behavior of the toast.
https://github.com/user-attachments/assets/1d03a5f4-8f49-4223-9871-a70ad6b534ec
Scenario
No response
Design
No response
Technical Details
The two problematic tests are these
it
blocks:allows simultaneous granting and revoking of multiple chain permissions
should add network permission when requested
Keep in mind they are flakey, specifically on Android and not iOS.
Threat Modeling Framework
No response
Acceptance Criteria
The Multchain workflow should pass consistently. Be sure to run the workflow at least 3 times to confirm it is fixed. Use the
multichain_permissions_e2e_pipeline
to confirm the multichain tests are running as expected instead of running smoke.Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: