Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Mobile controller decoupling #12870

Open
4 of 40 tasks
Cal-L opened this issue Jan 8, 2025 · 0 comments
Open
4 of 40 tasks

[EPIC] Mobile controller decoupling #12870

Cal-L opened this issue Jan 8, 2025 · 0 comments

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Jan 8, 2025 •
edited by mathieuartu
Loading

What is this about?

This is an epic that tracks the controller decoupling work as outlined here here - https://www.notion.so/metamask-consensys/Architecture-decoupling-refinement-175f86d67d68806c8f2cdfd32ec83544?pvs=4 with the main goal of increasing developer velocity by also decoupling code ownership.

Tasks:

Scenario

  • TBD

Design

No response

Technical Details

  • TBD

Threat Modeling Framework

No response

Acceptance Criteria

  • TBD

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@Cal-L Cal-L changed the title [EPIC] Engine decoupling for working group [EPIC] Mobile Engine decoupling Jan 8, 2025
@Cal-L Cal-L changed the title [EPIC] Mobile Engine decoupling [EPIC] Mobile controller decoupling Jan 8, 2025
@mathieuartu mathieuartu mentioned this issue Mar 6, 2025
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 6, 2025
@mathieuartu @tommasini
feat: bump profile-sync-controller and migrate to the controller init…
1823778 
… pattern (#13859)

## **Description**

This PR bumps `@metamask/profile-sync-controller` to `^9.0.0`.
It also migrates `AuthenticationController` and `UserStorageController`
to the new controller init pattern.

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-55
Related to: 
- #12968
- #13840
- #12870

## **Manual testing steps**

No user facing changes.
Verifying that notifications work should suffice.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cal-L