Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cannot add Network from settings #12836

Closed
salimtb opened this issue Jan 6, 2025 · 0 comments · Fixed by #12833
Closed

[Bug]: Cannot add Network from settings #12836

salimtb opened this issue Jan 6, 2025 · 0 comments · Fixed by #12833
Labels
regression-prod-7.37 Regression bug that was found in production in release 7.37 release-7.40.0 Issue or pull request that will be included in release 7.40.0 team-wallet-api-platform type-bug Something isn't working

Comments

@salimtb
Copy link
Contributor

salimtb commented Jan 6, 2025

Describe the bug

as a user ai'm not able to add networks from the settings menu

Expected behavior

No response

Screenshots/Recordings

Image

Steps to reproduce

  1. Go to settings
  2. Go to networks
  3. Go to add networks then custom networks

Error messages or log output



Detection stage


In production (default)


Version


7.37


Build type


None


Device


iphone 14


Operating system


Android, iOS


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @salimtb
salimtb




          added
  the 

  type-bug

  Something isn't working
 label


      Jan 6, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 6, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Jan 6, 2025

    

  



  

  

    
  


  

      

    @salimtb
salimtb



    mentioned this issue
    
      Jan 6, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  regression-prod-7.37

  Regression bug that was found in production in release 7.37
 label


      Jan 6, 2025

    

  



    


  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Jan 7, 2025
    
    

      


  

    

      


  

      
        @salimtb
  





      

        
          fix: fix add network form when addMode is true (#12833)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          82d7f87
        
      

    

  

    

      
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
fix the add network form when addMode is true

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #12836

## **Manual testing steps**

1. Go to settings
2. Go to networks
3. Go to add networks then custom networls

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="500" alt="Screenshot 2025-01-02 at 23 40 52"
src="https://github.com/user-attachments/assets/83b0d9de-6c5b-48cf-959a-53ce40a46541"
/>

<!-- [screenshots/recordings] -->

### **After**

<img width="415" alt="Screenshot 2025-01-02 at 23 41 43"
src="https://github.com/user-attachments/assets/bbe697ed-f31a-428e-b06e-fe3b0b7ed86f"
/>


<!-- [screenshots/recordings] -->


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by team


      Jan 7, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-7.40.0

  Issue or pull request that will be included in release 7.40.0
 label


      Jan 7, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    regression-prod-7.37

  Regression bug that was found in production in release 7.37
  

    release-7.40.0

  Issue or pull request that will be included in release 7.40.0
  

    team-wallet-api-platform

  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: Fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: fix add network form when addMode is true

    
      MetaMask/metamask-mobile
    





    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @smilingkylan 
        
          @salimtb 
        
          @metamaskbot