[Bug]: App error when navigating to token details page #12660
Assignees
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
regression-develop
Regression bug that was found on main branch, but not yet present in production
release-7.38.0
Issue or pull request that will be included in release 7.38.0
release-7.40.0
Issue or pull request that will be included in release 7.40.0
release-blocker
This bug is blocking the next release
Sev1-high
An issue that may have caused fund loss or access to wallet in the past & may still be ongoing
type-bug
Something isn't working
Comments
sahar-fehri
added
the
portfolio-view
metamaskbot
added
the
regression-develop
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 12, 2024
## **Description** PR to fix app crash when user navigates to token details page. ## **Related issues** Fixes: #12660 ## **Manual testing steps** 1. Click on any asset in your wallet 2. Click on options (3 dots) top right 3. Click on Token Details 4. You should see token details without an app crash ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/e5b53a50-8294-4b63-80ff-41cfe9fb45e2 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.38.0
|
@sahar-fehri it seems like I am still getting app crash when viewing token details.... Additional Token details causing crashes...
Pattern seems to be viewing token details for a networks native token. If we want this to work consistently, then it should work like it does for ETH, tokens details is not an option to select/view for network native tokens. Token details should only be available to select for non-native tokens. |
|
Reproduced for the following popular native tokens: BNB, AVAX,POL, PALM Token.details.error.native.tokens.mov |
gauthierpetetin
added
the
Sev1-high
|
The fix works Screen.Recording.2025-01-08.at.16.58.08.mov |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2025
## **Description** PR to fix options displayed in Asset Options bottom sheet. ## **Related issues** Fixes: #12660 (comment) ## **Manual testing steps** 1. Click on a native token on any network 2. Click on asset options button on top right 3. Notice that you should not see "Token Details" option ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/db23c1df-4e2b-46cb-a0f4-ea976005d4ea ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.40.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When the user navigates to token details page, app crashes.
Expected behavior
Navigate successfully to token details
Screenshots/Recordings
No response
Steps to reproduce
Error messages or log output
Cannot read property of undefinedDetection stage
On main branch
Version
7.38
Build type
None
Device
Android pixel pro 5
Operating system
Android
Additional context
Screen.Recording.2024-12-12.at.16.05.18.mov
Severity
No response
The text was updated successfully, but these errors were encountered: