Upgrade @metamask/swaps-controller to 12.0.0
#12470
Assignees
Labels
Comments
7 tasks
mcmire
changed the title
@metamask/swaps-controller to 12.0.0@metamask/swaps-controller to 12.0.0 (when it is released)
mcmire
changed the title
@metamask/swaps-controller to 12.0.0 (when it is released)@metamask/swaps-controller to 12.0.0
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2025
## Description This version upgrades `@metamask/swaps-controller` so that it is less reliant on the global network. Specifically: - The `setChainId` and `setProvider` methods have been removed from SwapsController. - The `fetchGasFeeEstimates` and `fetchEstimatedMultiLayerL1Fee` SwapsController constructor options are now expected to take a `networkClientId`. - The SwapsController constructor no longer takes a `chainId` option. - `startFetchAndSetQuotes`, `fetchTokenWithCache`, `fetchTopAssetsWithCache`, and `fetchAggregatorMetadataWithCache` now take a `networkClientId`. - The `fetchParamsMetaData` SwapsController state property now includes a `networkClientId`. - The chain cache in SwapsController state will now automatically be updated whenever the network has changed. See full changelog here: https://github.com/MetaMask/swaps-controller/blob/main/CHANGELOG.md#1200 At the moment, the global network client ID is still passed into SwapsController whenever it is used, but now that can be changed to use a dapp-level network client ID without needing to update SwapsController. ## Related issues Fixes #12470. Also see: - MetaMask/swaps-controller#347 - MetaMask/swaps-controller#204 ## Manual testing steps - Tap on the Swap button - Select a destination token and proceed - You should see new quotes - Ideally, you should be able to complete the swaps flow and create a transaction ## Screenshots/Recordings The Swaps flow should work exactly like it does now. Here is a video demonstrating fetching Swaps quotes: https://github.com/user-attachments/assets/62a490c9-32c4-49a2-886d-136328761658 ## Pre-merge author checklist - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## Pre-merge reviewer checklist - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.40.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
This PR to add support for multichain to SwapsController is released under 12.0.0. We should upgrade mobile to bring in this change.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: