[Bug]: Fiat value displayed only for the native token #11901
Assignees
Labels
regression-RC-7.34.0
Regression bug that was found in release candidate (RC) for release 7.34.0
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
team-confirmations
Push issues to confirmations team
type-bug
Something isn't working
Comments
sleepytanya
added
type-bug
7 tasks
bschorchit
added
the
Sev2-normal
NicolasMassart
pushed a commit
that referenced
this issue
Oct 24, 2024
…11947) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [In the recent changes](https://github.com/MetaMask/core/pull/4364/files) token exchange rates are determined from `marketData` which has no `value` property anymore. Hence `fetchTokenContractExchangeRates` was failing because rather than `value` it should now read `price` Please note that this is already fixed in `main` in the `assets-controllers@33`. ## **Related issues** Fixes: #11901 ## **Manual testing steps** 1. Simulations should show fiat values properly ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After**  ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Closing as completed with #11947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Fiat value displayed only for the native token, for all other tokens
Not Availablemessage is shown.Expected behavior
Fiat values displayed for all tokens on all networks
Screenshots/Recordings
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
7.34.0 (1462)
Build type
None
Device
iPhone 15, Samsung S24+
Operating system
iOS, Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: