Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.1 #11134

Closed
9 tasks
MajorLift opened this issue Sep 10, 2024 · 1 comment · Fixed by #12225
Closed
9 tasks

chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.1 #11134

MajorLift opened this issue Sep 10, 2024 · 1 comment · Fixed by #12225
Assignees
@mikesposito
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

What is this about?

The PPOMController is behind by two major versions and needs to be updated.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@MajorLift MajorLift self-assigned this Sep 10, 2024
@MajorLift MajorLift mentioned this issue Sep 10, 2024
Closed
7 tasks
@desi
Copy link
Contributor

desi commented Oct 3, 2024

This is blocked by #213

@kanthesha kanthesha assigned mikesposito and unassigned MajorLift Oct 10, 2024
@mikesposito mikesposito changed the title chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.34.0 chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.0 Oct 14, 2024
This was referenced Oct 14, 2024
Closed
Closed
@cryptodev-2s cryptodev-2s changed the title chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.0 chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.1 Nov 7, 2024
@cryptodev-2s cryptodev-2s mentioned this issue Nov 7, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2024
@cryptodev-2s @mikesposito
chore: bump @metamask/ppom-validator to 0.35.1 (#12225)
09fa44a 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps `@metamask/ppom-validator` to `0.35.1`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #11134

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-wallet-framework
Projects
None yet
Milestone
No milestone
4 participants
@desi @MajorLift @mikesposito @metamaskbot