Skip to content

Commit

Permalink
fix: Disable SES on iOS (#8057)
Browse files Browse the repository at this point in the history
## **Description**

This PR disables SES due to crashing issues associated with enabling
SES.

## **Related issues**

Fixes: #8054 

## **Manual testing steps**

1. Got to optimism
2. Trigger a transaction and observe crash when hitting confirm

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
  • Loading branch information
sethkfman and leotm authored Dec 8, 2023
1 parent 94b149a commit d0baa69
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
18.18
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
"fs": "react-native-level-fs"
},
"engines": {
"node": "^18.17.1",
"node": "~18.18.2",
"yarn": "^1.22.0"
},
"lavamoat": {
Expand Down
8 changes: 5 additions & 3 deletions patches/react-native+0.71.14.patch
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
diff --git a/node_modules/react-native/Libraries/Core/InitializeCore.js b/node_modules/react-native/Libraries/Core/InitializeCore.js
index 1379ffd..340f48d 100644
index 1379ffd..e59f511 100644
--- a/node_modules/react-native/Libraries/Core/InitializeCore.js
+++ b/node_modules/react-native/Libraries/Core/InitializeCore.js
@@ -24,26 +24,51 @@
@@ -24,26 +24,53 @@

'use strict';

+const Platform = require('../Utilities/Platform');
+
+if (Platform.OS === 'ios' && !global?.HermesInternal) {
+const IS_LOCKDOWN_ENABLED = false; // Temporarily false until CI issues investigated and resolved
+
+if (IS_LOCKDOWN_ENABLED && Platform.OS === 'ios' && !global?.HermesInternal && !__DEV__) {
+ require('../../../../ses.cjs'); // ses@0.18.8
+ /**
+ * Without consoleTaming: 'unsafe' causes:
Expand Down

0 comments on commit d0baa69

Please sign in to comment.