Skip to content

Commit

Permalink
fix: Update Basic Functionality settings description.json (#9781)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Adds copy to explain:
- What happens when toggle is enabled/disabled
- Basics of internet services and exposing IP addresses (we’re not doing
anything out of the ordinary)
- IP address use by us is temporary and limited
- We never sell user data

## **Related issues**
Fixes: MetaMask/MetaMask-planning#2560

## **Manual testing steps**
Onboarding
1. Go to Onboarding > Default Settings
2. Check copy under Basic Functionality
3. Check link to Privacy Policy

Settings
1. Go to Setttings > Privacy and Security
2. Check copy under Basic Functionality
3. Check link to Privacy Policy

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
#table markdown template
| Before       | After        |
|--------------|--------------|
| <img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM"
src="https://github.com/MetaMask/metamask-mobile/assets/165834542/07e7e4fe-a97d-4244-b789-cf235171857d">
|<img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM"
src="https://github.com/MetaMask/metamask-mobile/assets/165834542/23c9aaf2-16c2-4ba2-b1ee-8eb9016b2dbe">
|

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: EtherWizard33 <eric.lamontagne@consensys.net>
Co-authored-by: EtherWizard33 <165834542+EtherWizard33@users.noreply.github.com>
  • Loading branch information
3 people authored May 30, 2024
1 parent 62388a7 commit 9b33a3e
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 6 deletions.
11 changes: 10 additions & 1 deletion app/components/UI/BasicFunctionality/BasicFunctionality.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { View, Switch } from 'react-native';
import { View, Switch, Linking } from 'react-native';
import Text, {
TextVariant,
TextColor,
Expand All @@ -10,6 +10,7 @@ import { useSelector } from 'react-redux';
import { RootState } from '../../../../app/reducers';
import styles from './BasicFunctionality.styles';
import { BasicFunctionalityComponentProps } from './BasicFunctionality.types';
import AppConstants from '../../../core/AppConstants';

export default function BasicFunctionalityComponent({
handleSwitchToggle,
Expand All @@ -20,6 +21,10 @@ export default function BasicFunctionalityComponent({
(state: RootState) => state?.settings?.basicFunctionalityEnabled,
);

const handleLink = () => {
Linking.openURL(AppConstants.URLS.PRIVACY_POLICY_2024);
};

return (
<View style={styles.setting}>
<View style={styles.heading}>
Expand All @@ -39,6 +44,10 @@ export default function BasicFunctionalityComponent({
</View>
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('default_settings.functionality_body')}
<Text color={TextColor.Info} onPress={handleLink}>
{strings('default_settings.privacy_policy')}
</Text>
{strings('default_settings.functionality_body2')}
</Text>
</View>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,24 @@ exports[`BasicFunctionality should render correctly 1`] = `
}
}
>
Includes token data and value, optimal gas settings, security updates, and more. Using these services shares your IP address with MetaMask, just like when you visit a website.
MetaMask offers basic features like token details and gas settings through internet services. When you use internet services, your IP address is shared, in this case with MetaMask. This is just like when you visit any website. MetaMask uses this data temporarily and never sells your data. You can use a VPN or turn off these services, but it may affect your MetaMask experience. Read our
<Text
accessibilityRole="text"
onPress={[Function]}
style={
{
"color": "#0376C9",
"fontFamily": "Euclid Circular B",
"fontSize": 14,
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
Privacy policy
</Text>
to learn more.
</Text>
</View>
`;
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,24 @@ exports[`DefaultSettings should render correctly 1`] = `
}
}
>
Includes token data and value, optimal gas settings, security updates, and more. Using these services shares your IP address with MetaMask, just like when you visit a website.
MetaMask offers basic features like token details and gas settings through internet services. When you use internet services, your IP address is shared, in this case with MetaMask. This is just like when you visit any website. MetaMask uses this data temporarily and never sells your data. You can use a VPN or turn off these services, but it may affect your MetaMask experience. Read our
<Text
accessibilityRole="text"
onPress={[Function]}
style={
{
"color": "#0376C9",
"fontFamily": "Euclid Circular B",
"fontSize": 14,
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
Privacy policy
</Text>
to learn more.
</Text>
</View>
<View
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,24 @@ exports[`SecuritySettings should render correctly 1`] = `
}
}
>
Includes token data and value, optimal gas settings, security updates, and more. Using these services shares your IP address with MetaMask, just like when you visit a website.
MetaMask offers basic features like token details and gas settings through internet services. When you use internet services, your IP address is shared, in this case with MetaMask. This is just like when you visit any website. MetaMask uses this data temporarily and never sells your data. You can use a VPN or turn off these services, but it may affect your MetaMask experience. Read our
<Text
accessibilityRole="text"
onPress={[Function]}
style={
{
"color": "#0376C9",
"fontFamily": "Euclid Circular B",
"fontSize": 14,
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
Privacy policy
</Text>
to learn more.
</Text>
</View>
</View>
Expand Down
5 changes: 3 additions & 2 deletions locales/languages/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -3031,7 +3031,8 @@
"manage_networks": "Manage networks",
"manage_networks_body": "We use Infura as our remote procedure call (RPC) provider to offer the most reliable and private access to Ethereum data we can. You can choose your own RPC, but remember that any RPC will receive your IP address and Ethereum wallet to make transactions. Read our ",
"manage_networks_body2": " to learn more about how Infura handles data.",
"functionality_body": "Includes token data and value, optimal gas settings, security updates, and more. Using these services shares your IP address with MetaMask, just like when you visit a website.",
"functionality_body": "MetaMask offers basic features like token details and gas settings through internet services. When you use internet services, your IP address is shared, in this case with MetaMask. This is just like when you visit any website. MetaMask uses this data temporarily and never sells your data. You can use a VPN or turn off these services, but it may affect your MetaMask experience. Read our ",
"functionality_body2": " to learn more.",
"sheet": {
"title_off": "Turn off basic functionality",
"description_off": "This means you won't fully optimize your time on MetaMask. Basic features (like token details, optimal gas settings, and others) won't be available to you.",
Expand All @@ -3055,4 +3056,4 @@
"tooltip_description": "Estimated changes are what might happen if you go through with this transaction. This is just a prediction, not a guarantee.",
"total_fiat": "Total {{currency}}"
}
}
}

0 comments on commit 9b33a3e

Please sign in to comment.