-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The network names for Ethereum mainnet and Linea mainnet should be standardized as "Ethereum Mainnet" and "Linea" to align with our third-party provider. core PR: [adjust network names](MetaMask/core#4865) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #11895 ## **Manual testing steps** 1. Move from v7.33 ( or any previous release version ) to this branch 2. Check the name of Ethereum mainnet and Linea ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information
Showing
6 changed files
with
39 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
diff --git a/node_modules/@metamask/controller-utils/dist/types.cjs b/node_modules/@metamask/controller-utils/dist/types.cjs | ||
index b8c00f2..6268fb0 100644 | ||
--- a/node_modules/@metamask/controller-utils/dist/types.cjs | ||
+++ b/node_modules/@metamask/controller-utils/dist/types.cjs | ||
@@ -97,11 +97,11 @@ exports.BlockExplorerUrl = { | ||
[BuiltInNetworkName.LineaMainnet]: 'https://lineascan.build', | ||
}; | ||
exports.NetworkNickname = { | ||
- [BuiltInNetworkName.Mainnet]: 'Mainnet', | ||
+ [BuiltInNetworkName.Mainnet]: 'Ethereum Mainnet', | ||
[BuiltInNetworkName.Goerli]: 'Goerli', | ||
[BuiltInNetworkName.Sepolia]: 'Sepolia', | ||
[BuiltInNetworkName.LineaGoerli]: 'Linea Goerli', | ||
[BuiltInNetworkName.LineaSepolia]: 'Linea Sepolia', | ||
- [BuiltInNetworkName.LineaMainnet]: 'Linea Mainnet', | ||
+ [BuiltInNetworkName.LineaMainnet]: 'Linea', | ||
}; | ||
//# sourceMappingURL=types.cjs.map |