Skip to content

Commit

Permalink
dedupe dependencies and ignore ts error on engine that needs network …
Browse files Browse the repository at this point in the history
…controller be updated
  • Loading branch information
tommasini committed Mar 6, 2024
1 parent 147a231 commit 3a9c12c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
2 changes: 2 additions & 0 deletions app/core/Engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,8 @@ class Engine {
onNetworkStateChange: (listener) =>
this.controllerMessenger.subscribe(
AppConstants.NETWORK_STATE_CHANGE_EVENT,
// @ts-expect-error network controller will be updated on this PR: https://github.com/MetaMask/metamask-mobile/pull/8812 and this type error will be addressed
// This is not a blocker because gas fee controller does not need ticker to be defined
listener,
),
// @ts-expect-error at this point in time the provider will be defined by the `networkController.initializeProvider`
Expand Down
23 changes: 2 additions & 21 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3616,18 +3616,7 @@
immer "^9.0.6"
nanoid "^3.1.31"

"@metamask/approval-controller@^3.3.0":
version "3.4.0"
resolved "https://registry.yarnpkg.com/@metamask/approval-controller/-/approval-controller-3.4.0.tgz#282900361d42f785578728b45014ff8cb5e557ea"
integrity sha512-DjqrhiX9+W/Fh6Crr7FPJ87Y/uhPWzBvfXGtekv1LHZNmEtUxkrA7aelddUM0fpTdURIGT4aNGBoQudFidc+Lw==
dependencies:
"@metamask/base-controller" "^3.0.0"
"@metamask/utils" "^5.0.2"
eth-rpc-errors "^4.0.2"
immer "^9.0.6"
nanoid "^3.1.31"

"@metamask/approval-controller@^3.5.0":
"@metamask/approval-controller@^3.3.0", "@metamask/approval-controller@^3.5.0":
version "3.5.2"
resolved "https://registry.yarnpkg.com/@metamask/approval-controller/-/approval-controller-3.5.2.tgz#c8ca4578f053d719bff82b0c9fa1939d21978d46"
integrity sha512-5jYMtPexeeNL8m+5Mzhayr1l367MbbBs0Wf+FBeL/xLv6nSNqvvNs/CXfvkqxLDZJKIgBCBPKg7eIu1U6MJ6ag==
Expand Down Expand Up @@ -4369,15 +4358,7 @@
"@metamask/utils" "^5.0.0"
fast-safe-stringify "^2.0.6"

"@metamask/rpc-errors@^6.0.0", "@metamask/rpc-errors@^6.1.0":
version "6.1.0"
resolved "https://registry.yarnpkg.com/@metamask/rpc-errors/-/rpc-errors-6.1.0.tgz#dfdef7cba4b9ad01ca3f99e990b5980575b89b4f"
integrity sha512-JQElKxai26FpDyRKO/yH732wI+BV90i1u6pOuDOpdADSbppB2g1pPh3AGST1zkZqEE9eIKIUw8UdBQ4rp3VTSg==
dependencies:
"@metamask/utils" "^8.1.0"
fast-safe-stringify "^2.0.6"

"@metamask/rpc-errors@^6.2.1":
"@metamask/rpc-errors@^6.0.0", "@metamask/rpc-errors@^6.1.0", "@metamask/rpc-errors@^6.2.1":
version "6.2.1"
resolved "https://registry.yarnpkg.com/@metamask/rpc-errors/-/rpc-errors-6.2.1.tgz#f5daf429ededa7cb83069dc621bd5738fe2a1d80"
integrity sha512-VTgWkjWLzb0nupkFl1duQi9Mk8TGT9rsdnQg6DeRrYEFxtFOh0IF8nAwxM/4GWqDl6uIB06lqUBgUrAVWl62Bw==
Expand Down

0 comments on commit 3a9c12c

Please sign in to comment.