fix: sonar coverage path (#7187)

* update coverage path

* added step to generate lcov file

* update lcov generation command

* updated lcovinstruction

* updated coverage path for upload

* removed locv command merged it into merge command

* Update package.json yarn test:merge-coverage

* add exclusion for ppom lib file

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

.github/workflows/ci.yml

@@ -114,7 +114,7 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: coverage
-          path: ./tests/merged-coverage/coverage.json
+          path: ./tests/merged-coverage/lcov.info
           if-no-files-found: error
       - name: Require clean working directory
         shell: bash
@@ -133,7 +133,7 @@ jobs:
       - uses: actions/download-artifact@v3
         with:
           name: coverage
-          path: tests/coverage/
+          path: coverage/
       - name: Upload coverage reports to Codecov
         if: ${{ always() }}
         uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70

jest.config.js

@@ -21,6 +21,7 @@ const config = {
     '__mocks__/',
     '<rootDir>/app/util/test/',
     '<rootDir>/app/util/testUtils/',
+    '<rootDir>/app/lib/ppom/ppom.html.js',
   ],
   coverageReporters: ['text-summary', 'lcov'],
   coverageDirectory: '<rootDir>/tests/coverage',

package.json

@@ -67,7 +67,7 @@
     "test:depcheck": "yarn depcheck",
     "test:tgz-check": "./scripts/tgz-check.sh",
     "test:attribution-check": "./scripts/attributions-check.sh",
-    "test:merge-coverage": "nyc merge ./tests/coverage ./tests/merged-coverage/coverage.json",
+    "test:merge-coverage": "nyc report --temp-dir ./tests/coverage --report-dir ./tests/merged-coverage/ --reporter json --reporter text --reporter lcovonly",
     "test:validate-coverage": "nyc check-coverage --nycrc-path ./coverage-thresholds.json -t ./tests/merged-coverage/",
     "sourcemaps:android": "node_modules/.bin/react-native bundle --platform android --entry-file index.js --dev false --reset-cache --bundle-output /tmp/bundle.android.js --assets-dest /tmp/ --sourcemap-output sourcemaps/android/index.js.map",
     "sourcemaps:ios": "node_modules/.bin/react-native bundle --platform ios --entry-file index.js --dev false --reset-cache --bundle-output /tmp/bundle.ios.js --assets-dest /tmp/ --sourcemap-output sourcemaps/ios/index.js.map",

sonar-project.properties

@@ -14,8 +14,8 @@ sonar.sources=app/
 # Inclusions for test files.
 sonar.test.inclusions=**.test.**
 
-# Test coverage path
-sonar.javascript.lcov.reportPaths=/tests/coverage/lcov.info
+# Test coverage path in GitHub action
+sonar.javascript.lcov.reportPaths=/coverage/lcov.info
 
 # Encoding of the source code. Default is default system encoding
 #sonar.sourceEncoding=UTF-8