Skip to content

Commit

Permalink
feat: 1957 crash screen redesign (#12015)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Refactors ErrorBoundary to match [updated designs in
Figma](https://www.figma.com/design/DM5G1pyp74sMJwyKbw1KiR/Error-message-and-bug-report?node-id=1-5473&node-type=section&t=98CWfEC4JrKwpNCE-0)

## **Related issues**

Fixes: [#1957](MetaMask/mobile-planning#1957)

## **Manual testing steps**

1. Go WalletView
2. Add:
    ```
    useEffect(() => {
      throw new Error('Test Error');
    }, []);
    ```
3. Restart the app
4. Dismiss the Red Screen
5. See the new Error Screen

## TESTING THE BUILD:
1. Create a QA build in Bitrise
2. force an error
3. report the error
4. check
[Sentry](https://metamask.sentry.io/feedback/?feedbackSlug=test-metamask-mobile%3A6031686409&mailbox=ignored&project=2651591&referrer=feedback_list_page&statsPeriod=30d)
5. Should see user feedback in the Sentry report
6. Example:

![image](https://github.com/user-attachments/assets/c1737758-5739-48f9-96d1-798e523f5be3)


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
<img width="753" alt="image"
src="https://github.com/user-attachments/assets/136542c2-1578-4e87-9922-154f21a70c4e">


### **After**

<!-- [screenshots/recordings] -->



https://github.com/user-attachments/assets/7dbe5e04-0152-41bc-984a-37cba98c4eeb


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Daniel Cross <dan.s.cross@icloud.com>
  • Loading branch information
frankvonhoven and Daniel-Cross authored Nov 8, 2024
1 parent 2af2f67 commit 3091e43
Show file tree
Hide file tree
Showing 4 changed files with 529 additions and 405 deletions.
Loading

0 comments on commit 3091e43

Please sign in to comment.