Skip to content

Commit

Permalink
fix: locks api spec version for api spec tests (#11084)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Ideally the api-specs that is used should not be pointing at latest, it
should be locked to a version. The downstream execution apis was updated
and included in our spec and needs some fixes. In the meantime this
locks the version to the previous one.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. run `yarn test:e2e:ios:debug:build`
2. run `yarn test:api-specs`
3. see that it passes

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Curtis David <Curtis.David7@gmail.com>
  • Loading branch information
shanejonas and cortisiko authored Sep 10, 2024
1 parent de47a6c commit 1b6959f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ stages:
- android_e2e_build: {}
run_smoke_e2e_ios_android_stage:
workflows:
# - run_ios_api_specs: {} flakiness in pipeline. Disabling for now
- run_ios_api_specs: {}
- run_tag_smoke_accounts_ios: {}
- run_tag_smoke_accounts_android: {}
- run_tag_smoke_assets_ios: {}
Expand Down
2 changes: 1 addition & 1 deletion e2e/api-specs/json-rpc-coverage.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const chainId = 1337;

const main = async () => {
const openrpcDocument = await parseOpenRPCDocument(
'https://metamask.github.io/api-specs/latest/openrpc.json',
'https://metamask.github.io/api-specs/0.10.8/openrpc.json',
);

const signTypedData4 = openrpcDocument.methods.find(
Expand Down

0 comments on commit 1b6959f

Please sign in to comment.