Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use content-hash@2.5.2 #9051

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Use content-hash@2.5.2 #9051

merged 1 commit into from
Jul 22, 2020

Conversation

whymarrh
Copy link
Contributor

Refs #9037

This PR updates our content-hash version to the latest published version. I don't believe this change alone fixes #9037.

@whymarrh whymarrh requested a review from a team as a code owner July 22, 2020 16:51
@whymarrh
Copy link
Contributor Author

You can see a more detailed discussion here: ensdomains/ens-app#849. This was recently fixed in ENS which can be viewed here: ensdomains/ui#77.

Neither of these issues suggest that the fix is in content-hash itself, we may need to decode different data, à la ensdomains/ui#77.

Gudahtt
Gudahtt approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 33430f6 into MetaMask:develop Jul 22, 2020
@whymarrh whymarrh deleted the update-content-hash branch July 22, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENS resolving for IPNS names
2 participants
@whymarrh @Gudahtt