Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "delete" button when editing contact of wallet account #9030

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Hide "delete" button when editing contact of wallet account #9030

merged 1 commit into from
Jul 17, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 17, 2020

Wallet accounts can't be deleted from the contact list. This button never worked, nor should it.

@Gudahtt
Hide "delete" button when editing contact of wallet account
c7837ce 
Wallet accounts can't be deleted from the contact list. This button
never worked, nor should it.
@Gudahtt Gudahtt mentioned this pull request Jul 17, 2020
Merged
@Gudahtt Gudahtt marked this pull request as ready for review July 17, 2020 20:52
@Gudahtt Gudahtt requested a review from a team as a code owner July 17, 2020 20:52
@metamaskbot
Copy link
Collaborator

Builds ready [c7837ce]
Page Load Metrics (648 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30105582612
domContentLoaded4807906467033
load4817926486933
domInteractive4807896467033

@whymarrh
Copy link
Contributor

Under what conditions is showingMyAccounts set?

@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 17, 2020

showingMyAccounts means that the current route is /settings/contact-list/my-accounts/view or /settings/contact-list/my-accounts/edit (for view and edit contact respectively). This is the route for editing/viewing a wallet account contact.

The routes /settings/contact-list/view-contact and /settings/contact-list/edit-contact are used for viewing and editing a non-wallet contact.

whymarrh
whymarrh approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ea8fa58 into develop Jul 17, 2020
@Gudahtt Gudahtt deleted the hide-contact-delete-button-for-wallet-accounts branch July 17, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh