Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc-cap@3.0.0 #8924

Merged
merged 3 commits into from
Jul 5, 2020
Merged

rpc-cap@3.0.0 #8924

merged 3 commits into from
Jul 5, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 5, 2020

  • rpc-cap@3.0.0
  • Adapt usage of rpc-cap per breaking changes
  • Rename PermissionsController.requestAccountsPermission to requestAccountsPermissionWithId, to highlight its purpose and distinguish it from other identically named functions

Fixes #8919

@rekmarks rekmarks requested a review from a team as a code owner July 5, 2020 19:17
Gudahtt
Gudahtt approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [3221f40]
Page Load Metrics (807 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33123733115
domContentLoaded4869278057838
load4909298077838
domInteractive4869268057938

@rekmarks rekmarks merged commit 8bc02d4 into develop Jul 5, 2020
@rekmarks rekmarks deleted the rpc-cap@3.0.0 branch July 5, 2020 19:49
@Gudahtt Gudahtt mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with subsquent 'eth_requestAccounts' without action to the first.
3 participants
@rekmarks @metamaskbot @Gudahtt