Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@metamask/inpage-provider@6.0.0 #8921

Merged
merged 1 commit into from
Jul 4, 2020
Merged

@metamask/inpage-provider@6.0.0 #8921

merged 1 commit into from
Jul 4, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 4, 2020 •
edited by Gudahtt
Loading

This restores the data event, and rolls back an accidental change made to the notification event. Both of these provider events should now behave exactly as they had in v7.7.9.

Fixes #8916

@rekmarks rekmarks requested a review from a team as a code owner July 4, 2020 16:48
@Gudahtt
Copy link
Member

Gudahtt commented Jul 4, 2020

I've added a description

Gudahtt
Gudahtt approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 916edc6 into develop Jul 4, 2020
@rekmarks rekmarks deleted the @metamask/inpage-provider@6.0.0 branch July 4, 2020 17:13
@metamaskbot
Copy link
Collaborator

Builds ready [23d189e]
Page Load Metrics (1180 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53157973416
domContentLoaded6261452117816278
load6281454118016378
domInteractive6251451117716278

This was referenced Jul 6, 2020
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

newBlockHeaders subscription is broken
3 participants
@rekmarks @Gudahtt @metamaskbot