Prevent showing connected accounts without origin #8891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [42c61de]
Page Load Metrics (646 ± 55 ms)
|
Base automatically changed from
set-empty-active-tab-if-no-valid-origin
to
develop
July 2, 2020 21:01
There was a case where the `activeTab.origin` was not set, yet the user could still navigate to the "Connected accounts" modal, which assumes that `activeTab.origin` is set. This would happen in Firefox when the user opened the popup on a page internal to Firefox (e.g. `about:blank`). The connected status indicator would still be shown, but the UI would crash when it was clicked. The connected status indicator is now hidden whenever `activeTab.origin` is falsy. The 'Unconnected account' alert has also been made impossible to trigger in that circumstance.
Gudahtt
force-pushed
the
prevent-showing-connected-accounts-when-no-active-tab-origin-is-set
branch
from
42c61de
to
c46e6a4
Compare
Builds ready [c46e6a4]
Page Load Metrics (906 ± 52 ms)
|
brad-decker
approved these changes
Jul 2, 2020
Gudahtt
deleted the
prevent-showing-connected-accounts-when-no-active-tab-origin-is-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case where the
activeTab.originwas not set, yet the user could still navigate to the "Connected accounts" modal, which assumes thatactiveTab.originis set. This would happen in Firefox when the user opened the popup on a page internal to Firefox (e.g.about:blank). The connected status indicator would still be shown, but the UI would crash when it was clicked.The connected status indicator is now hidden whenever
activeTab.originis falsy. The 'Unconnected account' alert has alsobeen made impossible to trigger in that circumstance.