-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URL origin instead of hostname for permission domains #8717
Conversation
Builds ready [74438ea]
Page Load Metrics (592 ± 53 ms)
|
We should update the phishing controller to expect an |
Builds ready [2a0265c]
Page Load Metrics (692 ± 81 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It would be nice to hide the "default" protocols and ports, so that our current designs effectively don't change. e.g. hide |
window.location.hostname
->window.location.origin
We should include the protocol and port in permission domain origin strings, because they can point to completely different entities.