Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hostname in the disconnect confirmation #8663

Merged
merged 1 commit into from
May 27, 2020

Conversation

whymarrh
Copy link
Contributor

This PR updates the disconnect confirmation modal to show the hostname instead of the document title. This aligns with the rest of the modals.

Before vs. after:

@whymarrh whymarrh marked this pull request as ready for review May 27, 2020 21:42
@whymarrh whymarrh requested a review from a team as a code owner May 27, 2020 21:42
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 3931427 into MetaMask:develop May 27, 2020
@whymarrh whymarrh deleted the fix-disconnect-modal-title branch May 27, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants