-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky position the tabs at the top #8609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:guy-fieri-chef-kiss:
What does this look like on the fullscreen view? Edit: Ah right - no tabs on the fullscreen view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this being set globally on the tab component 🤔 Could this have an effect the other places that component is used? I don't recall any of the other tab contents being long enough to scroll, so maybe not. |
Fixed.
I've check most of the other usages and they're all fine, namely the add token page and the gas customization modal. (I don't know currently know the conditions under which the confirm page will have tabs.)
|
It has tabs when confirming a contract interaction iirc. The second tab is "data", which could be pretty long. I can try to reproduce it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the home screen tabs to stick to the top of the screen when scrolling.
Gif
(It's slow to start, give it a second.)
Screenshots