Allow disabling alerts #8550
Merged
Allow disabling alerts #8550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
dont-show-me-this-alert-again
branch
2 times, most recently
from
26940cb
to
986eb48
Compare
Gudahtt
commented
May 7, 2020
ui/app/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js
Show resolved
Hide resolved
Gudahtt
force-pushed
the
dont-show-me-this-alert-again
branch
2 times, most recently
from
f4883a1
to
66fdb00
Compare
Screenshots:"Unconnected account" alert with the new checkbox:
"Unconnected account" alert with the new checkbox, showing the hover state of the info-icon:
Alert settings tab in settings menu:
Alert settings page:
|
Builds ready [66fdb00]
Page Load Metrics (652 ± 39 ms)
|
Gudahtt
force-pushed
the
dont-show-me-this-alert-again
branch
from
66fdb00
to
8a9c8f9
Compare
Builds ready [8a9c8f9]
Page Load Metrics (709 ± 43 ms)
|
whymarrh
suggested changes
May 8, 2020
Builds ready [5c4df55]
Page Load Metrics (666 ± 18 ms)
|
whymarrh
previously approved these changes
May 8, 2020
rachelcope
previously approved these changes
May 8, 2020
The unconnected account alert can now be disabled. A "don't show this again" checkbox has been added to the alert, which prevents that alert from being shown in the future. An alert settings page has been added to the settings as well. This page allows the user to disable or enable any alert.
The string `unconnectedAccount` is now stored as a constant. This was done to make it more clear that this string had to match exactly in each of these places.
Gudahtt
force-pushed
the
dont-show-me-this-alert-again
branch
from
740a4f4
to
e9bb114
Compare
|
@rachelcope Thanks, that does look better. It has been updated here: e9bb114 |
Builds ready [e9bb114]
Page Load Metrics (668 ± 18 ms)
|
Gudahtt
commented
May 8, 2020
whymarrh
approved these changes
May 8, 2020
Builds ready [82fec4f]
Page Load Metrics (670 ± 21 ms)
|
Gudahtt
added a commit
that referenced
this pull request
May 9, 2020
When disabling an alert, the background `alertEnabledness` state of the alert was being set to `undefined` instead of `false`. This didn't have any user-facing effect, since `undefined` is falsey, but it did result in a PropType error on the Alert settings page. This mistake was made in #8550. The `alertEnabledness` state is now correctly set to `false` instead of `undefined`.
Gudahtt
added a commit
that referenced
this pull request
May 9, 2020
When disabling an alert, the background `alertEnabledness` state of the alert was being set to `undefined` instead of `false`. This didn't have any user-facing effect, since `undefined` is falsey, but it did result in a PropType error on the Alert settings page. This mistake was made in #8550. The `alertEnabledness` state is now correctly set to `false` instead of `undefined`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unconnected account alert can now be disabled. A "don't show this again" checkbox has been added to the alert, which prevents that alert from being shown in the future.
An alert settings page has been added to the settings as well. This page allows the user to disable or enable any alert.