Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Delete Dai/Sai migration notification (#8418)" #8447

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 28, 2020

This backports the deletion of the Dai/Sai migration notification. Note that the migration to delete the now unused background state has not been included, as it is non-essential and would have been more difficult to backport. The migration to delete the unused state will be included in the next major release instead.

@Gudahtt Gudahtt marked this pull request as draft April 28, 2020 17:44
@Gudahtt Gudahtt force-pushed the backport-delete-sai-migration-notification branch 3 times, most recently from fa46fc6 to 6d4dbb4 Compare April 28, 2020 19:00
@Gudahtt Gudahtt marked this pull request as ready for review April 28, 2020 19:25
@Gudahtt Gudahtt requested a review from a team April 28, 2020 19:25
@metamaskbot
Copy link
Collaborator

Builds ready [6d4dbb4]

@Gudahtt Gudahtt force-pushed the backport-delete-sai-migration-notification branch from 6d4dbb4 to 67b5a87 Compare April 29, 2020 04:59
@metamaskbot
Copy link
Collaborator

Builds ready [67b5a87]

This backports the deletion of the Dai/Sai migration notification
(#8418). Note that the migration to delete the now unused background
state has not been included, as it is non-essential and would have been
more difficult to backport. The migration to delete the unused state
will be included in the next major release instead.
@Gudahtt Gudahtt force-pushed the backport-delete-sai-migration-notification branch from 67b5a87 to f370eed Compare April 29, 2020 05:32
@metamaskbot
Copy link
Collaborator

Builds ready [f370eed]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 57fdc03 into Version-v7.7.9 Apr 29, 2020
@Gudahtt Gudahtt deleted the backport-delete-sai-migration-notification branch April 29, 2020 14:40
@metamaskbot metamaskbot mentioned this pull request May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants