Adding setting for disabling Eth Phishing Detection #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
requested changes
Feb 27, 2020
ryanml
force-pushed
the
eth-phish-toggle
branch
from
4db0a36
to
67f05fc
Compare
Gudahtt
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8105
This is on by default, let me know too about the copy for the setting (there isn't a period for consistency in the code, I just didn't take a new screenshot):
This can be tested by switching the feature on and off and ensuring the phishing detection behaves appropriately, using this list: https://github.com/MetaMask/eth-phishing-detect/blob/master/src/hosts.txt