Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize the full size of icon space #7408

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Utilize the full size of icon space #7408

merged 2 commits into from
Nov 14, 2019

Conversation

sergejmueller
Copy link
Contributor

Increase the MetaMask icon size to the available browser action bar size. The "bigger" icon appears sharper and clearer.

Initial icon size
chrome-actionbar-metamask-before

Modified icon size
chrome-actionbar-metamask-after

@cjeria
Copy link
Contributor

cjeria commented Nov 14, 2019

Hey @sergejmueller thanks for suggesting this update! We'd be more than happy to update this icon.

We'd like to use our official front-facing logo as the icon. See example/
image

I've included all 3 version per chrome's spec https://developer.chrome.com/apps/manifest/icons

This zip should have all 3 image sizes.
extension_icon.zip

@sergejmueller
Copy link
Contributor Author

All icons are replaced by the front-facing logo. There are seven different sizes, they are all used in any extension files.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@cjeria the notification badge colour apparently needs to be changed at runtime - I'll submit a separate PR for that.

@Gudahtt Gudahtt merged commit fb83b29 into MetaMask:develop Nov 14, 2019
@cjeria
Copy link
Contributor

cjeria commented Nov 15, 2019

Here's the 512px sized icon for good measure.
icon512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants