Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the chainId to remove contact from state #7324

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Adds the chainId to remove contact from state #7324

merged 1 commit into from
Oct 29, 2019

Conversation

tmashuang
Copy link
Contributor

Fixes #7318

Gaba/AddressBookController requires a chainId to delete contact from state.
https://github.com/MetaMask/gaba/blob/develop/src/user/AddressBookController.ts#L83

@metamaskbot
Copy link
Collaborator

Builds ready [9285a10]

Gudahtt
Gudahtt approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@tmashuang tmashuang merged commit fd0f6bb into develop Oct 29, 2019
@tmashuang tmashuang deleted the delete-contact branch October 29, 2019 18:24
@tmashuang tmashuang changed the title Adds the chainId to remove accounts from state Adds the chainId to remove contact from state Oct 29, 2019
@tmashuang tmashuang mentioned this pull request Nov 3, 2019
Closed
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to delete contact from contact list.
3 participants
@tmashuang @metamaskbot @Gudahtt