-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✔️ Issue #5742 update ens resolver to eip 1577 #6402
✔️ Issue #5742 update ens resolver to eip 1577 #6402
Conversation
see issue #5742 |
@danfinlay @kumavis this is ready for review 😁 |
Guys ? Is there anybody to review my PR ? |
Will need to fix |
PS: Here you can read discussion about the EIP1062, dappnode and the EIP1577. |
@pldespaigne I think supporting only |
Looks good to me then, just need to resolve the |
@danfinlay @bdresser @kumavis @whymarrh The conflict is solved, I just need a review now :) |
This dependency was used in our IPFS ENS resolver, but it has not been used directly since #6402.
For solving this issue I have used a small lib called
content-hash
. I have developped this lib to implement the content-hash encoding specified by the EIP1577. The code of the lib can be found here. This lib is trusted by the ENS team and it is currently used in the official ENS manager web app (discussion here, commit here).Because the purpose of the
content-hash
lib is to solve this exact issue, I have included it in thepackage.json
file.Detailed realisations :
You can test on ropsten with those link
errordomain.eth -> error : redirect to the ENS manager
dappsnation.eth -> legacy swarm content
ipfs.dappsnation.eth ->ipfs content-hash
swarm.dappsnation.eth ->ipfs content-hash