Refactor and Redesign Transaction List #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
previously requested changes
Jul 31, 2018
ui/app/i18n-provider.js
Outdated
| @@ -13,6 +13,9 @@ class I18nProvider extends Component { | |||
| t (key, ...args) { | |||
| return t(current, key, ...args) || t(en, key, ...args) || `[${key}]` | |||
| }, | |||
| tOrDefault (key, ...args) { | |||
There was a problem hiding this comment.
This could take a default argument e.g. tOrDefault(key, default, ...args) (or even just tOrDefault(key, default)) and then clients could pass in whatever default they want
alextsg
force-pushed
the
refactor-tx-list
branch
2 times, most recently
from
391b337 to
eba4422
Compare
alextsg
force-pushed
the
refactor-tx-list
branch
7 times, most recently
from
317a22e to
ae95b48
Compare
alextsg
force-pushed
the
refactor-tx-list
branch
2 times, most recently
from
72cb7c2 to
f3c9a28
Compare
alextsg
changed the title
|
Before: After: |
|
@alextsg wanna rebase this on develop to get the latest e2e improvements |
alextsg
force-pushed
the
refactor-tx-list
branch
from
1d19290 to
c298912
Compare
alextsg
force-pushed
the
refactor-tx-list
branch
8 times, most recently
from
19dce29 to
d851f58
Compare
alextsg
force-pushed
the
refactor-tx-list
branch
from
dc3f5cc to
342522c
Compare
… method in tx-list-items integration test.
danjm
approved these changes
Aug 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.