-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix e2e tests #4229
fix e2e tests #4229
Conversation
Hello @danfinlay @kumavis I noticed that your e2e and screen tests were failing, so I spent a few days to figure out a workaround to bring them to life. The solution is not the nicest, but maybe this is the least error prone way to get the development time extension id - without changing the manifest.json. This change has much lower risk as it cannot ruin the release package. |
Oh very nice, this may fix the test failure in #4199. We'll review this today. |
Meanwhile I could come up with a simpler solution. I will update the pull request in a few hours. |
@danfinlay updated with the less complicated solution. It has a little risk, because /deep/ css combinator is deprecated. I can see no warning though. If it stops working later then it can be replaced with the other solution. |
Thanks so much for this contribution. It turns out some other team members were working on the same issue, and have fixed it similarly in PR #4226, so I'm closing this for now, since it appears to be redundant. Thank you so much for jumping in and doing this, though! |
No description provided.