-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add background
Redux slice as proxy for unflattened background state
#29694
Draft
MajorLift
wants to merge
50
commits into
main
Choose a base branch
from
jongsun/perf/redux/2501141-add-background-redux-slice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Add background
Redux slice as proxy for unflattened background state
#29694
MajorLift
wants to merge
50
commits into
main
from
jongsun/perf/redux/2501141-add-background-redux-slice
+1,960
−600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define types for metamask controller stores
… are assigned composed controller state objects
… to use state properties
…mposedState` usage
…hange` listener and avoid iterating through entire `metamask` slice for every background state update
… and exposes their composed state via `.getState()`
…d state and individual controller states as input
…pdates to the entire background state or top-level non-object properties of background state
…re it can handle the unflattened background state
…kState` for inference of `metamask` slice type
…alMetamaskState`
…_BACKGROUND_STATE`
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
changed the base branch from
main
to
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
January 16, 2025 10:29
… slice at `ui/ducks/background`
MajorLift
force-pushed
the
jongsun/perf/redux/2501141-add-background-redux-slice
branch
from
January 16, 2025 11:12
6d32839
to
9fc832c
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/2501141-add-background-redux-slice
branch
from
January 16, 2025 17:32
9fc832c
to
2b1e3ea
Compare
MajorLift
changed the base branch from
jongsun/perf/redux/241008-unflatten-MetamaskController-stores
to
main
January 16, 2025 17:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Instead of unflattening the
metamask
Redux slice in-place, a newbackground
slice has been created as a placeholder or eventual replacement.Adopting a "horizontal sharding" approach, we will be iteratively transferring each controller's state properties from
metamask
tobackground
, simultaneously updating downstream references to point to thebackground
slice.Pros
metamask
slice.metamask
slice structure to be inconsistent and in flux while the transition takes place, introducing difficulties for feature development and potentially causing bugs.PatchStore
andComposableObservableStore
.Cons
Introduces temporary dead code into the codebase.background
slice will be documented extensively through comments and internal communications, so that feature teams are aware not to reference or modify it.Significantly increased memory usage
background
slice so that only migrated controller state is populated and updated.wrap background slice with devtime feature flagselector disentanglement for independent prs.
Consolidation of test mock objects (x) -> go through them individually to unflatten
Priority/urgency of clean-up tasks in phase 3 (especially regarding realization of selector memoization performance benefits)
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist