fix: Change visibility of AmountRow in contract interaction
#29131
+300
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,3 +33,80 @@ export const getAmountColors = (credit?: boolean, debit?: boolean) => { | |||
| } | |||
| return { color, backgroundColor }; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Perhaps it would be good to add unit tests to these util methods
| const simulationDataMock = { | ||
| tokenBalanceChanges: [], | ||
| nativeBalanceChange: { | ||
| difference: '0x3782dace9d900000' as Hex, |
There was a problem hiding this comment.
Can you use decimal test number constants and convert them to hex using a util, so the numbers are human readable?
There was a problem hiding this comment.
Make sense, done in 9a6e27a
jpuri
reviewed
Dec 12, 2024
| ): boolean { | ||
| const value = transactionMeta?.txParams?.value ?? '0x0'; | ||
| const nativeBalanceChange = | ||
| transactionMeta?.simulationData?.nativeBalanceChange; |
There was a problem hiding this comment.
It will be nice to test cover util methods also
Builds ready [7b160db]
Page Load Metrics (1728 ± 63 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Dec 12, 2024
jpuri
reviewed
Dec 12, 2024
| @@ -36,3 +41,103 @@ describe('getIsRevokeSetApprovalForAll', () => { | |||
| expect(actual).toEqual(true); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('hasValueAndNativeBalanceMismatch', () => { | |||
There was a problem hiding this comment.
Nit: if method is simulation specific and places in utils, may be we name it as something simulationHasValueAndNativeBalanceMismatch
jpuri
approved these changes
Dec 12, 2024
Builds ready [fcc975e]
Page Load Metrics (1826 ± 76 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.10.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two visibility change on
AmountRowin transaction details.AmountRowAmountRowmust be visible.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3783
Manual testing steps
Scenario I
Scenario II
{ to: "0x4805a248c9611c22a43ce956489c9aadb6108433", value: "0xDE0B6B3A7640000", data: "0x3158952e", }Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist