fix: block tracker stops polling when switching away from the network #29045

mikesposito · 2024-12-10T10:00:42Z

Description

This PR bumps @metamask/network-controller and @metamask/eth-json-rpc-middleware by a patch version to fix an issue related to @metamask/eth-block-tracker, used to listen to new blocks emitted by networks.

Related issues

Fixes: #17040

Manual testing steps

This only applies to views that show a single chain: since now the wallet home shows all networks, requests will be fired regardless of the globally selected network. To test this, the chain filter in the home should be set to a specific chain, instead of all

Add a local ganache network
Turn off the local ganache server
Observe requests failing when navigating to the home of the wallet (while showing all networks)
Filter a single chain which is not the local one (e.g. mainnet)
Polling to localhost should stop

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-12-10T10:01:49Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/network-controller@22.1.0

View full report↗︎

metamaskbot · 2024-12-10T10:35:02Z

Builds ready [b7f5958]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1889 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1581	2384	1885	207	99
		domContentLoaded	1572	2354	1860	203	97
		load	1582	2449	1889	215	103
		domInteractive	24	80	37	16	8
		backgroundConnect	9	93	31	24	11
		firstReactRender	15	85	26	20	9
		getState	76	393	149	78	37
		initialActions	0	1	0	0	0
		loadScripts	1191	1833	1464	183	88
		setupStore	7	76	12	15	7
		uiStartup	1868	2874	2236	270	130

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 2.94 KiB (0.04%)

package.json

.yarn/patches/@metamask-network-controller-npm-22.1.1-09b6510f1e.patch

socket-security · 2024-12-10T13:12:48Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

mikesposito · 2024-12-10T13:38:29Z

@SocketSecurity ignore npm/reselect@3.0.1

This package version was published 8 years ago, and is not being changed in this PR

metamaskbot · 2024-12-10T13:49:19Z

Builds ready [45b2aa5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1957 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	183	2479	1860	430	207
		domContentLoaded	1628	2448	1937	202	97
		load	1648	2474	1957	201	96
		domInteractive	23	102	37	17	8
		backgroundConnect	7	60	20	16	8
		firstReactRender	16	94	27	22	10
		getState	101	358	160	68	33
		initialActions	0	0	0	0	0
		loadScripts	1263	1980	1525	174	83
		setupStore	7	13	8	2	1
		uiStartup	1865	2902	2331	294	141

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 2.94 KiB (0.04%)

Gudahtt

LGTM!

mcmire

I have confirmed that requests no longer occur via the block tracker for a failing network when switching away.

mikesposito · 2024-12-12T09:55:41Z

Resolved conflicts

metamaskbot · 2024-12-12T10:26:41Z

Builds ready [c20642f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1628 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1408	1954	1629	136	65
		domContentLoaded	1395	1919	1605	132	64
		load	1405	1952	1628	138	66
		domInteractive	23	111	42	22	11
		backgroundConnect	8	73	26	19	9
		firstReactRender	16	78	46	25	12
		getState	4	38	8	7	3
		initialActions	0	1	0	0	0
		loadScripts	964	1464	1184	117	56
		setupStore	6	43	9	8	4
		uiStartup	1643	2185	1833	143	69

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt · 2024-12-17T16:38:40Z

Ah sorry, I pushed a commit to fix the lock file but then realized immediately after that the branch was outdated, so I removed it again. Sorry for that.

The branch needs an update, but in addition to that, there's a bunch of changes in the lockfile that don't seem to be necessary. I'd recommend resetting the lockfile from main (git checkout origin/main yarn.lock && yarn && yarn dedupe) to get rid of those.

metamaskbot · 2024-12-18T11:37:49Z

Builds ready [521ab4e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1661 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1430	1770	1658	85	41
		domContentLoaded	1423	1762	1635	79	38
		load	1431	1774	1661	89	43
		domInteractive	21	100	41	22	10
		backgroundConnect	9	75	30	21	10
		firstReactRender	15	104	44	32	15
		getState	4	40	10	8	4
		initialActions	0	1	0	0	0
		loadScripts	1027	1332	1211	77	37
		setupStore	6	77	25	26	13
		uiStartup	1633	2513	1971	233	112

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-18T17:30:26Z

Builds ready [f1e746b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1840 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	383	2219	1769	371	178
		domContentLoaded	1480	2191	1822	189	91
		load	1485	2198	1840	189	91
		domInteractive	27	79	48	18	9
		backgroundConnect	8	60	26	18	9
		firstReactRender	17	98	60	28	14
		getState	5	55	14	13	6
		initialActions	0	0	0	0	0
		loadScripts	1054	1696	1356	174	84
		setupStore	6	83	24	25	12
		uiStartup	1805	2990	2197	291	140

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt

LGTM!

mikesposito added 2 commits December 10, 2024 10:54

chore(deps): bump @metamask/network-controller to ^22.1.1

e2dbdbe

chore: bump @metamask/eth-json-rpc-middleware

b7f5958

metamaskbot added the team-wallet-framework label Dec 10, 2024

mikesposito changed the title ~~Mikesposito/deps/network controller~~ fix: block tracker stops polling when switching away from the network Dec 10, 2024

mikesposito marked this pull request as ready for review December 10, 2024 10:02

Gudahtt reviewed Dec 10, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

update network-controller patch

58c5bac

mikesposito commented Dec 10, 2024

View reviewed changes

.yarn/patches/@metamask-network-controller-npm-22.1.1-09b6510f1e.patch Outdated Show resolved Hide resolved

mikesposito added 2 commits December 10, 2024 14:15

fix: add PATCH.txt

f035311

yarn dedupe

45b2aa5

mikesposito requested a review from Gudahtt December 10, 2024 13:38

Gudahtt previously approved these changes Dec 10, 2024

View reviewed changes

mcmire previously approved these changes Dec 11, 2024

View reviewed changes

Merge branch 'main' into mikesposito/deps/network-controller

c20642f

mikesposito dismissed stale reviews from mcmire and Gudahtt via c20642f December 12, 2024 09:54

mikesposito requested review from mcmire and Gudahtt December 12, 2024 09:55

mikesposito enabled auto-merge December 12, 2024 17:07

Merge branch 'main' into mikesposito/deps/network-controller

d470307

mcmire previously approved these changes Dec 16, 2024

View reviewed changes

mikesposito disabled auto-merge December 16, 2024 16:24

Gudahtt dismissed mcmire’s stale review via 4ad13db December 17, 2024 16:36

Gudahtt force-pushed the mikesposito/deps/network-controller branch from 4ad13db to d470307 Compare December 17, 2024 16:37

mikesposito added 2 commits December 18, 2024 12:02

reset yarn.lock

66fc579

Merge branch 'main' into mikesposito/deps/network-controller

521ab4e

mikesposito requested a review from mcmire December 18, 2024 13:39

mikesposito added 2 commits December 18, 2024 14:39

Merge branch 'main' into mikesposito/deps/network-controller

2af6a0b

Merge branch 'main' into mikesposito/deps/network-controller

f1e746b

Gudahtt approved these changes Dec 18, 2024

View reviewed changes

mikesposito enabled auto-merge December 18, 2024 17:32

cryptodev-2s approved these changes Dec 18, 2024

View reviewed changes

mikesposito added this pull request to the merge queue Dec 18, 2024

Merged via the queue into main with commit f8a1d4f Dec 18, 2024
77 checks passed

mikesposito deleted the mikesposito/deps/network-controller branch December 18, 2024 18:24

github-actions bot locked and limited conversation to collaborators Dec 18, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: block tracker stops polling when switching away from the network #29045

fix: block tracker stops polling when switching away from the network #29045

mikesposito commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading

metamaskbot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 •

edited

Loading

mikesposito commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

Gudahtt left a comment

mcmire left a comment

mikesposito commented Dec 12, 2024

metamaskbot commented Dec 12, 2024

Gudahtt commented Dec 17, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

Gudahtt left a comment

fix: block tracker stops polling when switching away from the network #29045

fix: block tracker stops polling when switching away from the network #29045

Conversation

mikesposito commented Dec 10, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

socket-security bot commented Dec 10, 2024 • edited Loading

metamaskbot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 • edited Loading

mikesposito commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

Gudahtt left a comment

Choose a reason for hiding this comment

mcmire left a comment

Choose a reason for hiding this comment

mikesposito commented Dec 12, 2024

metamaskbot commented Dec 12, 2024

Gudahtt commented Dec 17, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

Gudahtt left a comment

Choose a reason for hiding this comment

mikesposito commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading