feat: migrate base mainnet rpc to infura #28974

salimtb · 2024-12-05T20:17:54Z

Description

This PR introduces a migration to replace the Base network RPC URL (https://mainnet.base.org) with the new Infura RPC URL (https://base-mainnet.infura.io/v3/{infuraProjectId}) in the MetaMask state.

Acceptance Criteria:

Migrate Base Mainnet to Infura only if users are using an Infura RPC as the default on at least one supported network, excluding testnets and Linea Mainnet.

Related issues

Fixes:

Manual testing steps

build the app on main branch and put the file on tmp-chrome folder
Add base network
build the app on the current branch
replace the main build with the new one
base url should be updated

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-05T20:18:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/scripts/migrations/135.ts

…infura.io

app/scripts/migrations/135.ts

salimtb · 2024-12-05T21:09:52Z

shared/constants/network.ts

+  'bsc-mainnet.infura.io',
+  'mantle-mainnet.infura.io',
+  'opbnb-mainnet.infura.io',
+  'scroll-mainnet.infura.io',


testnet are included here, i addded this list because of the comment above from github-advanced-security

where did you get this list?

i got it from infura doc here

testnet are excluded now

danjm · 2024-12-05T21:32:35Z

Code looks good. I will do a manual test

salimtb · 2024-12-05T21:32:44Z

app/scripts/migrations/135.ts

+          const urlHost = new URL(defaultRpcEndpoint.url).host;
+          return (
+            defaultRpcEndpoint.type === RpcEndpointType.Infura ||
+            allowedInfuraHosts.includes(urlHost)


doing this because some infura network can be added as custom network

metamaskbot · 2024-12-05T22:07:51Z

Builds ready [c71d569]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1900 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1663	2245	1895	155	74
		domContentLoaded	1657	2191	1864	148	71
		load	1662	2249	1900	156	75
		domInteractive	24	98	39	20	10
		backgroundConnect	7	79	36	21	10
		firstReactRender	15	92	22	16	8
		getState	77	275	133	42	20
		initialActions	0	1	0	0	0
		loadScripts	1263	1696	1439	133	64
		setupStore	7	72	11	14	7
		uiStartup	1887	2673	2210	228	110

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.03 KiB (0.04%)
ui: 0 Bytes (0.00%)
common: 891 Bytes (0.01%)

metamaskbot · 2024-12-05T23:45:50Z

Builds ready [919d18b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2009 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	240	2403	1921	415	199
		domContentLoaded	1746	2318	1979	147	71
		load	1755	2398	2009	153	74
		domInteractive	25	63	34	10	5
		backgroundConnect	9	76	30	21	10
		firstReactRender	15	93	25	18	9
		getState	103	300	145	41	20
		initialActions	0	0	0	0	0
		loadScripts	1315	1852	1516	139	67
		setupStore	7	78	15	20	10
		uiStartup	2056	2854	2362	238	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.12 KiB (0.04%)
ui: 0 Bytes (0.00%)
common: 988 Bytes (0.01%)

metamaskbot added the team-assets label Dec 5, 2024

salimtb changed the title ~~Salim/migrate base mainnet rpc to infura~~ feat: migrate base mainnet rpc to infura Dec 5, 2024

salimtb force-pushed the salim/migrate-base-mainnet-rpc-to-infura branch from 8819652 to b6ae9e4 Compare December 5, 2024 20:35

github-advanced-security bot found potential problems Dec 5, 2024

View reviewed changes

app/scripts/migrations/135.ts Fixed Show fixed Hide fixed

feat: migrate Base network RPC from mainnet.base.org to base-mainnet.…

0d2ae6e

…infura.io

salimtb force-pushed the salim/migrate-base-mainnet-rpc-to-infura branch from b6ae9e4 to 0d2ae6e Compare December 5, 2024 20:44

github-advanced-security bot found potential problems Dec 5, 2024

View reviewed changes

app/scripts/migrations/135.ts Fixed Show fixed Hide fixed

salimtb commented Dec 5, 2024

View reviewed changes

salimtb force-pushed the salim/migrate-base-mainnet-rpc-to-infura branch from f23cf64 to 282122f Compare December 5, 2024 21:24

fix: fix security comment

5eec9b4

salimtb force-pushed the salim/migrate-base-mainnet-rpc-to-infura branch from 282122f to 5eec9b4 Compare December 5, 2024 21:24

salimtb marked this pull request as ready for review December 5, 2024 21:28

salimtb requested a review from danjm December 5, 2024 21:30

salimtb commented Dec 5, 2024

View reviewed changes

fix: fix linter

c71d569

salimtb added 2 commits December 5, 2024 23:49

fix: exclude testnet

7d3f428

fix: exclude linea mainnet

919d18b

danjm approved these changes Dec 5, 2024

View reviewed changes

darkwing approved these changes Dec 5, 2024

View reviewed changes

salimtb added this pull request to the merge queue Dec 5, 2024

Merged via the queue into main with commit 4fc45f0 Dec 6, 2024
75 checks passed

salimtb deleted the salim/migrate-base-mainnet-rpc-to-infura branch December 6, 2024 00:14

github-actions bot locked and limited conversation to collaborators Dec 6, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate base mainnet rpc to infura #28974

feat: migrate base mainnet rpc to infura #28974

salimtb commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024

salimtb Dec 5, 2024 •

edited

Loading

danjm Dec 5, 2024

salimtb Dec 5, 2024

salimtb Dec 5, 2024

danjm commented Dec 5, 2024

salimtb Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

feat: migrate base mainnet rpc to infura #28974

feat: migrate base mainnet rpc to infura #28974

Conversation

salimtb commented Dec 5, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 5, 2024

salimtb Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

danjm Dec 5, 2024

Choose a reason for hiding this comment

salimtb Dec 5, 2024

Choose a reason for hiding this comment

salimtb Dec 5, 2024

Choose a reason for hiding this comment

danjm commented Dec 5, 2024

salimtb Dec 5, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

salimtb commented Dec 5, 2024 •

edited

Loading

salimtb Dec 5, 2024 •

edited

Loading