fix: display new network popup only for accounts that are compatible. #28535

montelaidev · 2024-11-19T09:54:30Z

Description

This PR updates the new network popup to only show up for accounts that supports it.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/660

Manual testing steps

On flask, enable BTC experimental feature and create an account.
Switch to an EVM account
Add a different RPC such as base
See 'You're now using` alert for the added network
tap Got it
Tap the account picker and select BTC account
See that the new network popup does not show.
tap BTC under tokens
See that the new network popup does not show.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-19T09:54:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-19T13:05:41Z

Builds ready [88b3f0b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1849 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2246	1779	363	174
		domContentLoaded	1638	2131	1816	116	56
		load	1661	2251	1849	136	65
		domInteractive	27	67	40	12	6
		backgroundConnect	12	120	34	27	13
		firstReactRender	48	116	67	17	8
		getState	43	102	84	17	8
		initialActions	0	1	0	0	0
		loadScripts	1193	1601	1355	100	48
		setupStore	6	16	7	2	1
		uiStartup	1871	2688	2098	175	84

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 342 Bytes (0.00%)
common: 296 Bytes (0.00%)

ui/pages/routes/routes.component.test.js

ui/pages/routes/routes.component.js

shared/lib/multichain.ts

metamaskbot · 2024-11-20T08:02:11Z

Builds ready [3024b8b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1988 ± 125 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1617	2687	1984	263	126
		domContentLoaded	1603	2658	1961	261	125
		load	1611	2687	1988	260	125
		domInteractive	14	232	52	47	22
		backgroundConnect	9	80	30	20	10
		firstReactRender	52	105	74	14	7
		getState	43	126	94	18	8
		initialActions	0	1	0	0	0
		loadScripts	1159	2044	1473	224	108
		setupStore	6	48	10	9	4
		uiStartup	1857	3082	2268	299	144

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 342 Bytes (0.00%)
common: 311 Bytes (0.00%)

metamaskbot · 2024-11-21T05:38:11Z

Builds ready [ece7d0f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1996 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	260	2280	1842	511	245
		domContentLoaded	1686	2216	1952	151	73
		load	1752	2273	1996	161	77
		domInteractive	16	130	44	25	12
		backgroundConnect	11	79	46	23	11
		firstReactRender	89	165	120	20	10
		getState	7	82	22	21	10
		initialActions	0	1	0	0	0
		loadScripts	1228	1703	1438	138	66
		setupStore	6	56	12	12	6
		uiStartup	1959	2697	2220	185	89

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 342 Bytes (0.00%)
common: 311 Bytes (0.00%)

metamaskbot · 2024-11-22T13:41:48Z

Builds ready [610cf1f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1890 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	296	2142	1723	488	234
		domContentLoaded	1645	2146	1857	139	67
		load	1666	2152	1890	143	69
		domInteractive	20	214	50	42	20
		backgroundConnect	11	82	35	22	10
		firstReactRender	54	155	100	22	10
		getState	6	58	18	18	9
		initialActions	0	1	0	0	0
		loadScripts	1162	1626	1365	123	59
		setupStore	6	56	17	17	8
		uiStartup	1862	2381	2091	151	73

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 342 Bytes (0.00%)
common: 311 Bytes (0.00%)

ccharly

LGTM + tested:

shared/lib/multichain.ts

montelaidev added 2 commits November 14, 2024 11:42

fix: new network popup displayed for btc accounts

c903222

feat: add tests for network popup

b72d963

montelaidev self-assigned this Nov 19, 2024

montelaidev added the team-accounts label Nov 19, 2024

montelaidev added 3 commits November 19, 2024 17:55

Merge remote-tracking branch 'origin/develop' into fix/ap-660

8c9efaf

fix: lint

b48bc3a

fix: e2e test

88b3f0b

montelaidev marked this pull request as ready for review November 19, 2024 13:02

montelaidev requested a review from a team as a code owner November 19, 2024 13:02

ccharly reviewed Nov 19, 2024

View reviewed changes

ui/pages/routes/routes.component.test.js Outdated Show resolved Hide resolved

ui/pages/routes/routes.component.test.js Show resolved Hide resolved

ui/pages/routes/routes.component.js Show resolved Hide resolved

shared/lib/multichain.ts Show resolved Hide resolved

fix: add comments and handle undefined currentChainId

3024b8b

montelaidev requested a review from ccharly November 20, 2024 16:23

Merge remote-tracking branch 'origin/develop' into fix/ap-660

ece7d0f

Merge branch 'develop' into fix/ap-660

610cf1f

ccharly approved these changes Nov 25, 2024

View reviewed changes

danroc approved these changes Nov 25, 2024

View reviewed changes

gantunesr reviewed Nov 25, 2024

View reviewed changes

shared/lib/multichain.ts Show resolved Hide resolved

montelaidev added this pull request to the merge queue Nov 25, 2024

Merged via the queue into develop with commit 232a0f8 Nov 25, 2024
75 checks passed

montelaidev deleted the fix/ap-660 branch November 25, 2024 11:39

github-actions bot locked and limited conversation to collaborators Nov 25, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: display new network popup only for accounts that are compatible. #28535

fix: display new network popup only for accounts that are compatible. #28535

montelaidev commented Nov 19, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

ccharly left a comment

fix: display new network popup only for accounts that are compatible. #28535

fix: display new network popup only for accounts that are compatible. #28535

Conversation

montelaidev commented Nov 19, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

ccharly left a comment

Choose a reason for hiding this comment

montelaidev commented Nov 19, 2024 •

edited by github-actions bot

Loading