Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide "interacting with" when simulated balance changes are shown #28409

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 11, 2024

Description

The "Interacting with" section is shown only if the simulated changes are empty, if there was a simulation error or if the advanced details view is toggled on.

Open in GitHub Codespaces

Related issues

Fixes: #28309

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 11, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 11, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner November 11, 2024 14:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [22e5107]
Page Load Metrics (1993 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27225311660692332
domContentLoaded167924981958235113
load169425521993249119
domInteractive299947178
backgroundConnect10123393115
firstReactRender553851107134
getState55815136
initialActions01000
loadScripts12071965144220699
setupStore586252512
uiStartup188531802241317152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 613 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo changed the title fix: Hide interacting with when simulated balance changes are shown fix: Hide "interacting with" when simulated balance changes are shown Nov 13, 2024
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit c5c59df Nov 14, 2024
85 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/28309 branch November 14, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only display interacting with for token transfers within advanced view when simulations is unavailable
4 participants