fix: Removing warning prop from settings

[NiranjanaBinoy]

Description

Even though warning property is still used in the setting-tab and security-tab, we are no longer using displayWarning to update the error from the settings. This makes the error displayed in the tabs irrelevant to the component. So with this PR we are removing the warning property from settings-tab and security-tab.
We are removing the warning property from advance-tab in #26999

Related issues

Related to #25838

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0f80da0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1902 ± 137 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	335	2490	1801	429	206
		domContentLoaded	1552	2435	1872	286	137
		load	1563	2442	1902	285	137
		domInteractive	17	98	49	22	11
		backgroundConnect	8	64	31	19	9
		firstReactRender	44	133	93	24	11
		getState	5	49	13	12	6
		initialActions	0	1	0	0	0
		loadScripts	1136	1908	1417	251	121
		setupStore	10	76	24	21	10
		uiStartup	1749	2698	2097	312	150

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -294 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

LGTM

[metamaskbot]

Builds ready [82a60e4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2062 ± 140 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	297	2733	1899	607	291
		domContentLoaded	1719	2718	2041	289	139
		load	1727	2755	2062	292	140
		domInteractive	26	178	59	40	19
		backgroundConnect	7	69	25	21	10
		firstReactRender	48	294	111	62	30
		getState	5	82	26	25	12
		initialActions	0	1	0	0	0
		loadScripts	1186	2067	1505	261	125
		setupStore	12	95	32	24	12
		uiStartup	1914	3043	2308	309	148

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -294 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [64555ad]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1945 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	362	2254	1864	378	182
		domContentLoaded	1675	2243	1904	158	76
		load	1683	2316	1945	165	79
		domInteractive	16	233	52	45	22
		backgroundConnect	9	68	36	21	10
		firstReactRender	50	210	97	31	15
		getState	5	68	25	23	11
		initialActions	0	1	0	0	0
		loadScripts	1176	1740	1406	140	67
		setupStore	12	74	27	21	10
		uiStartup	1863	2483	2157	181	87

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -294 Bytes (-0.00%)
• common: 0 Bytes (0.00%)