test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27736

NiranjanaBinoy · 2024-10-09T17:46:47Z

Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication.

Description

Related issues

Fixes: #27119

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-09T17:46:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-10-09T18:21:08Z

Builds ready [db813f3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1852 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1589	2168	1847	144	69
		domContentLoaded	1556	2119	1816	137	66
		load	1589	2174	1852	143	69
		domInteractive	26	178	50	34	16

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-09T21:26:53Z

Builds ready [53d6415]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1649 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	337	2421	1522	428	206
		domContentLoaded	1466	2398	1621	188	90
		load	1476	2481	1649	200	96
		domInteractive	17	90	41	20	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-10-15T19:33:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-15T19:58:46Z

Builds ready [132f2b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1957 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1679	2522	1946	206	99
		domContentLoaded	1629	2409	1904	187	90
		load	1680	2561	1957	223	107
		domInteractive	19	104	48	21	10
		backgroundConnect	10	309	55	68	32
		firstReactRender	53	335	115	64	31
		getState	5	150	26	35	17
		initialActions	0	1	0	0	0
		loadScripts	1198	1727	1410	142	68
		setupStore	12	186	44	41	20
		uiStartup	1842	3715	2260	425	204

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

DDDDDanica · 2024-10-17T22:51:05Z

LGTM ! Thanks!

hjetpoluru

LGTM

…ication

metamaskbot · 2024-10-24T20:49:36Z

Builds ready [d8b711b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2124 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	339	2498	1956	526	252
		domContentLoaded	1922	2482	2096	131	63
		load	1938	2496	2124	131	63
		domInteractive	33	95	59	19	9
		backgroundConnect	7	69	26	20	10
		firstReactRender	51	285	127	59	28
		getState	7	71	31	24	12
		initialActions	0	1	0	0	0
		loadScripts	1404	1956	1567	118	57
		setupStore	12	70	36	24	11
		uiStartup	2154	2860	2417	194	93

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-24T22:07:22Z

Builds ready [8da653f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1866 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1701	2506	1874	179	86
		domContentLoaded	1670	2386	1827	162	78
		load	1696	2511	1866	181	87
		domInteractive	17	82	37	18	9
		backgroundConnect	9	125	36	33	16
		firstReactRender	48	191	99	30	14
		getState	4	70	17	20	10
		initialActions	0	0	0	0	0
		loadScripts	1238	1792	1361	130	62
		setupStore	10	76	29	25	12
		uiStartup	1879	3077	2101	262	126

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

hjetpoluru

LGTM

NiranjanaBinoy added the team-extension-platform label Oct 9, 2024

NiranjanaBinoy self-assigned this Oct 9, 2024

NiranjanaBinoy force-pushed the stream-unit-test-scratch-work branch from db813f3 to 53d6415 Compare October 9, 2024 20:53

NiranjanaBinoy changed the title ~~Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication~~ test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication Oct 15, 2024

NiranjanaBinoy force-pushed the stream-unit-test-scratch-work branch from 7c90692 to 132f2b7 Compare October 15, 2024 19:22

NiranjanaBinoy marked this pull request as ready for review October 15, 2024 20:49

NiranjanaBinoy requested a review from a team as a code owner October 15, 2024 20:49

NiranjanaBinoy requested a review from a team October 15, 2024 20:49

DDDDDanica previously approved these changes Oct 17, 2024

View reviewed changes

hjetpoluru self-requested a review October 24, 2024 19:45

hjetpoluru previously approved these changes Oct 24, 2024

View reviewed changes

NiranjanaBinoy added 2 commits October 24, 2024 15:55

unit test for setupPhishingCommunication and setUpCookieHandlerCommun…

63394c3

…ication

updating test

d8b711b

NiranjanaBinoy dismissed stale reviews from hjetpoluru and DDDDDanica via d8b711b October 24, 2024 20:13

NiranjanaBinoy force-pushed the stream-unit-test-scratch-work branch from 132f2b7 to d8b711b Compare October 24, 2024 20:13

NiranjanaBinoy requested review from hjetpoluru and DDDDDanica October 24, 2024 20:23

fixing rebase issue

8da653f

hjetpoluru approved these changes Oct 28, 2024

View reviewed changes

danjm assigned danjm and unassigned NiranjanaBinoy Nov 4, 2024

HowardBraham approved these changes Nov 24, 2024

View reviewed changes

HowardBraham added this pull request to the merge queue Nov 24, 2024

Merged via the queue into develop with commit 9eff241 Nov 24, 2024
76 checks passed

HowardBraham deleted the stream-unit-test-scratch-work branch November 24, 2024 17:06

github-actions bot locked and limited conversation to collaborators Nov 24, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27736

test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27736

NiranjanaBinoy commented Oct 9, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

sonarqubecloud bot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

DDDDDanica commented Oct 17, 2024

hjetpoluru left a comment

metamaskbot commented Oct 24, 2024

metamaskbot commented Oct 24, 2024

hjetpoluru left a comment

test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27736

test: Adding unit test for setupPhishingCommunication and setUpCookieHandlerCommunication #27736

Conversation

NiranjanaBinoy commented Oct 9, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

sonarqubecloud bot commented Oct 15, 2024

Quality Gate passed

metamaskbot commented Oct 15, 2024

DDDDDanica commented Oct 17, 2024

hjetpoluru left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 24, 2024

metamaskbot commented Oct 24, 2024

hjetpoluru left a comment

Choose a reason for hiding this comment

NiranjanaBinoy commented Oct 9, 2024 •

edited by github-actions bot

Loading