feat: migrate OnboardingController to BaseController v2

[cryptodev-2s]

Description

This PR updates OnboardingController to inherit from BaseController V2.

Details about other changes are to come...

Related issues

Fixes: #25927

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (5053c3e) to head (7aa9438).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
app/scripts/controllers/onboarding.ts	80.00%	3 Missing ⚠️
app/scripts/background.js	0.00%	2 Missing ⚠️
app/scripts/lib/account-tracker.js	66.67%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26880   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1426     1426           
  Lines        49705    49711    +6     
  Branches     13905    13905           
========================================
+ Hits         34853    34858    +5     
- Misses       14852    14853    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [a8567e6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1757 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	226	2083	1529	555	266
		domContentLoaded	1539	2068	1737	136	65
		load	1548	2088	1757	141	68
		domInteractive	18	164	42	32	15

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 453 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [1af5b44]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1750 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	413	2071	1674	322	155
		domContentLoaded	1526	1980	1723	127	61
		load	1535	2073	1750	146	70
		domInteractive	13	58	33	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 447 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mikesposito]

This looks good overall! I just added a couple of small comments

[metamaskbot]

Builds ready [782a17b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1729 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	249	2371	1513	548	263
		domContentLoaded	1491	2357	1713	177	85
		load	1499	2363	1729	174	84
		domInteractive	13	77	39	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 447 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[mikesposito]

LGTM!

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • ✅ Tested onboarding from fresh install
  • ✅ Tested with an already onboarded account
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [7aa9438]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1800 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	2416	1720	379	182
		domContentLoaded	1570	2408	1782	184	88
		load	1579	2417	1800	184	88
		domInteractive	13	197	46	38	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 447 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[itsyoboieltr]

LGTM!