-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick(v12.1.1): Bump @metamask/eth-json-rpc-middleware
to ^14.0.0
(#26143)
#26626
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c4f5329
to
29d7f50
Compare
This comment was marked as outdated.
This comment was marked as outdated.
29d7f50
to
6498b33
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
77ae327
to
d6d7ca3
Compare
d6d7ca3
to
44264fa
Compare
We'll be targeting this for v12.1.1 instead, so I've temporarily labelled this as |
Builds ready [44264fa]
Page Load Metrics (251 ± 259 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.1 #26626 +/- ##
================================================
Coverage 69.84% 69.84%
================================================
Files 1371 1371
Lines 48791 48795 +4
Branches 13453 13455 +2
================================================
+ Hits 34074 34078 +4
Misses 14717 14717 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
f0d58d1
to
694db65
Compare
…from `^3.0.3` to `^4.0.2`
…es in `makeExpirySet`method
267aa11
to
b59c933
Compare
@metamaskbot update-policies |
Policies updated |
@@ -171,19 +176,28 @@ export const getInitialSendStateWithExistingTxState = (draftTxState) => ({ | |||
}); | |||
|
|||
export function createMockInternalAccount({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to partially cherry-pick a commit in develop
(#25980) that converts test/jest/mocks.js
into TypeScript, because the params types of createMockInternalAccount
were being incompletely inferred from the JavaScript code, causing conflicting type errors downstream. Supplying the correct type information in TypeScript was the only solution.
Builds ready [9df53e5]
Page Load Metrics (67 ± 21 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! But I think we can trim down these lock file changes further
@metamaskbot update-policies |
Policies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [433c309]
Page Load Metrics (243 ± 256 ms)
|
Builds ready [433c309]
Page Load Metrics (243 ± 256 ms)
|
No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0. |
Description
Cherry-pick of #26143 for
v12.1.0-rcv12.1.1-rc.This is a very different PR from the original, as I had to remove diffs to a significant amount of code that has not yet been introduced to the release candidate.
The diffs that were excluded here will need to be reapplied to a future release. I'm also keeping an eye out for new cherry-picks that may introduce changes requiring me to restore certain diffs.
Aligning
@metamask/eth-block-tracker
to^11.0.1
is deferred, as it's blocked by #26150, which is not included in this release candidate. The@metamask/transaction-controller
major version bump from^34.0.0
to^35.1.1
is also removed for now.See below for new changelog.
Changelog
Added
PPOMMiddlewareRequest
type forJsonRpcRequest
typesthat include the
securityAlertResponse
property.securityAlertResponse
is defined as both optional and nullable.PPOMRequest
type foreth-sendTransaction
requests.Changed
@metamask/eth-json-rpc-middleware
from^12.1.1
to
^14.0.0
.@trezor/connect-web
from9.2.2
to9.3.0
.Fixed
Params
generic parameter ofcreatePPOMMiddleware
function fromJsonRpcParams
to(string | { to: string })[]
.Params
generic parameter tohandleSnapRequest
function, whichis constrained by
Record<string, unknown>
and defaults toJsonRpcParams
.handleSnapRequest
can now be typed correctly with anyparams
object.
Security
0X
prefixwith
0x
, and contract address normalization is removed for decimal andoctal values.
eth_signTypedData_v4
fields tocause failures in blockaid's detectors.
a non-0x prefixed integer address.
disappears if a signed address is prefixed by "0X" instead of "0x".
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist