feat(sentry): Adding extensionId and installType to Sentry #26482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
force-pushed
the
extension-id-sentry
branch
from
ec8df4f
to
e9dfb1f
Compare
Gudahtt
reviewed
Aug 19, 2024
Gudahtt
reviewed
Aug 19, 2024
Gudahtt
reviewed
Aug 19, 2024
vthomas13
changed the title
Gudahtt
reviewed
Aug 19, 2024
Gudahtt
reviewed
Aug 19, 2024
Builds ready [925845a]
Page Load Metrics (102 ± 26 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26482 +/- ##
===========================================
- Coverage 70.02% 70.01% -0.01%
===========================================
Files 1408 1409 +1
Lines 49105 49115 +10
Branches 13735 13737 +2
===========================================
+ Hits 34383 34386 +3
- Misses 14722 14729 +7 ☔ View full report in Codecov by Sentry. |
vthomas13
force-pushed
the
extension-id-sentry
branch
2 times, most recently
from
e08698f
to
1c74bad
Compare
Builds ready [1c74bad]
Page Load Metrics (106 ± 31 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Gudahtt
reviewed
Aug 20, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
vthomas13
force-pushed
the
extension-id-sentry
branch
from
1c74bad
to
649e677
Compare
|
Added tests in 649e677 |
Builds ready [844d090]
Page Load Metrics (70 ± 7 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
* origin/develop: feat: Redesign Approve confirmation (#26464) fix: Fix MV2 build sourcemap upload (#26467) feat: Enable hardware wallets for smart transactions, sign a transaction only once (#26251) fix: Allowlist Snap UI card component (#26565) fix(deps): Bump `@metamask/eth-json-rpc-middleware` to `^14.0.0`, `@metamask/transaction-controller` to `^35.1.1` (#26143) fix: adding warning for origin on redesigned pages (#26306) fix: track `swapAndSend` transaction type (#26535)
Gudahtt
reviewed
Aug 21, 2024
| @@ -1,12 +1,13 @@ | |||
| import * as Sentry from '@sentry/browser'; | |||
| import { createModuleLogger, createProjectLogger } from '@metamask/utils'; | |||
| import { logger } from '@sentry/utils'; | |||
| import { AllProperties } from '../../../shared/modules/object.utils'; | |||
| import browser from 'webextension-polyfill'; | |||
| import { isManifestV3 } from '../../../shared/modules/mv3.utils'; | |||
There was a problem hiding this comment.
This was the only line with a conflict in the most recent merge with develop. I just had to preserve this import
|
Just merged with |
Gudahtt
approved these changes
Aug 21, 2024
DDDDDanica
approved these changes
Aug 21, 2024
|
Builds ready [3184f9f]
Page Load Metrics (79 ± 8 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
metamaskbot
added
the
release-12.5.0
gauthierpetetin
added
release-12.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to differentiate between errors from our published extension, and errors from side-loaded extensions or forks that we don't support. Adding
extensionIDto our Sentry logs helps us do that. Following @Gudahtt's suggestion to use https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/management/getSelf to addinstallTypeas well.Related issues
Fixes: #26444
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist