-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (patch): erc20 token prices on non-ETH networks #26450
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -0,0 +1,52 @@ | |||
diff --git a/dist/chunk-6W5EQ3JQ.js b/dist/chunk-6W5EQ3JQ.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I patched both the .js and .mjs files, because I wasn't sure which was necessary
Builds ready [ece9eff]
Page Load Metrics (139 ± 177 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.0.5 #26450 +/- ##
================================================
Coverage 65.75% 65.75%
================================================
Files 1372 1372
Lines 54782 54782
Branches 14262 14262
================================================
Hits 36020 36020
Misses 18762 18762 ☔ View full report in Codecov by Sentry. |
Description
Fixes an issue with erc20 token prices on networks where ETH is not the native currency.
When the price API does not support the native currency (e.g. MATIC), prices are fetched in ETH and an additional conversion hop is performed. But the extension was using the raw value without this additional hop.
This PR patches the relevant parts of MetaMask/core#4364.
Because that change is already in 12.1.0, this patch will no longer be needed in that version.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist