fix: Remove invalid providerConfig id #26310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
remove-obsolete-network-controller-state
to
develop
August 2, 2024 13:15
Gudahtt
force-pushed
the
remove-invalid-provider-config-id
branch
from
cc38f47 to
9dfec33
Compare
Gudahtt
changed the title
Gudahtt
changed the title
Gudahtt
commented
Aug 2, 2024
| it('does nothing if obsolete properties are not set and providerConfig is set to undefined', async () => { | ||
| const oldState = { | ||
| NetworkController: { | ||
| // This should be impossible because `undefined` cannot be returned from persisted state, |
There was a problem hiding this comment.
I discovered this when investigating this test failure: https://github.com/MetaMask/metamask-extension/actions/runs/10216054639/job/28266703200
Gudahtt
commented
Aug 2, 2024
| @@ -40,7 +41,7 @@ function removeObsoleteSnapControllerState( | |||
| if (!hasProperty(state, 'SnapController')) { | |||
| return; | |||
| } else if (!isObject(state.SnapController)) { | |||
| global.sentry.captureException( | |||
| global.sentry?.captureException?.( | |||
There was a problem hiding this comment.
Updating these to follow the convention in other migrations of not assuming this global is set. It should always be set in production, but one of the migrator tests doesn't set it and can blow up here.
Discovered while investigating this test failure:
https://github.com/MetaMask/metamask-extension/actions/runs/10216054639/job/28266703200
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26310 +/- ##
===========================================
+ Coverage 70.04% 70.05% +0.01%
===========================================
Files 1411 1411
Lines 50031 50050 +19
Branches 13812 13822 +10
===========================================
+ Hits 35042 35061 +19
Misses 14989 14989 ☔ View full report in Codecov by Sentry. |
Gudahtt
added
team-extension-platform
needs-dev-review
Builds ready [27d6dcc]
Page Load Metrics (284 ± 270 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Remove invalid `providerConfig.id` state. This was one possible explanation for some Sentry errors that we have been encountering in production. The diagnostic state attached to the error was not sufficient to confirm that this was the cause. Relates to #26309
Gudahtt
force-pushed
the
remove-invalid-provider-config-id
branch
from
27d6dcc to
90c5763
Compare
|
Builds ready [90c5763]
Page Load Metrics (230 ± 234 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
approved these changes
Aug 2, 2024
NiranjanaBinoy
approved these changes
Aug 2, 2024
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-12.4.0
gauthierpetetin
added
release-12.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove invalid
providerConfig.idstate. This was one possible explanation for some Sentry errors that we have been encountering in production. The diagnostic state attached to the error was not sufficient to confirm that this was the cause.Related issues
Relates to #26309 and #26320
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist