fix: Cherry-pick persistence fix to RC #26305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osableObservableStore` (#26280) ## **Description** Fixes a bug where `ComposableObservableStore` would allow non-persistent state properties in its `initialState`. This in turn would cause state properties flagged as non-persistent to be persisted until a controller state change. This PR addresses this by taking the `persist` flag into account when deriving the initial state for each controller. If the controller does not support `metadata` or persistence is disabled, everything should continue to work as-is. [](https://codespaces.new/MetaMask/metamask-extension/pull/26280?quickstart=1)
](https://codespaces.new/MetaMask/metamask-extension/pull/26280?quickstart=1){kind=link}
Builds ready [b1d9f79]
Page Load Metrics (126 ± 161 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks fcf474c to the RC.
Description from the original PR:
Fixes a bug where
ComposableObservableStorewould allow non-persistent state properties in itsinitialState. This in turn would cause state properties flagged as non-persistent to be persisted until a controller state change.This PR addresses this by taking the
persistflag into account when deriving the initial state for each controller. If the controller does not supportmetadataor persistence is disabled, everything should continue to work as-is.