-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Permit variants: PermitSingle, PermitBatch, PermitTransferFrom, PermitBatchTransferFrom, TradeOrder, Seaport #26107
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Thanks for the reviews @jpuri & @matthewwalsh0! I ended up adding more tests here which included snapshots. The snapshots added ~1500 lines of code. It helped me discover improvements. Hope this is fine. Else, let me know, and I can move them into a separate PR |
Quality Gate passedIssues Measures |
Builds ready [e6e6de5]
Page Load Metrics (506 ± 431 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Related bug found and fixed: #26292 |
Related bug and improvements: #26324 |
Description
Covered:
Additionally:
Blocker:
I caught a bug in this code. When we use tokenDecimals to display the amount, it might not be for the correct token if it is nested. Need to rework the logic to support nested tokenDecimals
Notes:
Related issues
Blocked by: #26105
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2644 (PermitSingle)
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2666 (PermitBatch)
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2701 (PermitTransferFrom)
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2702 (PermitBatchTransferFrom)
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2667 (Order)
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2646 (Seaport OrderComponents)
Manual testing steps
See repro steps in related issue tickets above
Screenshots/Recordings
Before
After
PermitSingle
PermitBatch
Seaport (OrderComponents)
Pre-merge author checklist
Pre-merge reviewer checklist