Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak spacing in send asset picker #25576

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

BZahory
Copy link
Contributor

@BZahory BZahory commented Jun 27, 2024

Description

The token symbol send page's asset picker is not vertically aligned with other dropdowns on the page. This PR removes an unneeded margin introduced in #25470.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to send page
  2. Ensure asset picker is spaced correctly and vertically aligned with other components

Screenshots/Recordings

Before

Screenshot 2024-06-27 at 5 55 08 PM

After

Screenshot 2024-06-27 at 5 58 37 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested a review from a team as a code owner June 27, 2024 21:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@BZahory BZahory added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 29, 2024
@BZahory BZahory force-pushed the send-page-asset-picker-spacing branch from 9a4c17c to 9604e0d Compare July 1, 2024 14:31
Copy link

sonarqubecloud bot commented Jul 1, 2024

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (699ddcc) to head (9604e0d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25576   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [9604e0d]
Page Load Metrics (152 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652911195125
domContentLoaded897342110
load411588152331159
domInteractive897342110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -14 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@BZahory BZahory merged commit 03b5d5e into develop Jul 1, 2024
73 checks passed
@BZahory BZahory deleted the send-page-asset-picker-spacing branch July 1, 2024 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 1, 2024
@BZahory BZahory removed the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants