Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account missing in connection page #25500

Merged
merged 13 commits into from
Jul 2, 2024
Merged

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jun 25, 2024

Description

This PR fixes a regression where the connected account is not showing up on the page.

Related issues

Fixes #25844

Manual testing steps

  1. Go to a test dapp
  2. Connect the account
  3. Open the popup
  4. Click on the connection icon and see the connected account.

Screenshots/Recordings

Before

Screenshot 2024-06-25 at 15 30 55

After

Screenshot 2024-06-25 at 15 31 01

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (198bedd) to head (7c41c46).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25500   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48173    +1     
  Branches     13291    13291           
========================================
+ Hits         33526    33527    +1     
  Misses       14646    14646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [95c4eb2]
Page Load Metrics (49 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671078294
domContentLoaded9211232
load41654973
domInteractive9211232
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 67 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev marked this pull request as ready for review June 25, 2024 17:13
@montelaidev montelaidev requested review from a team as code owners June 25, 2024 17:13
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 26, 2024
NidhiKJha
NidhiKJha previously approved these changes Jun 27, 2024
ccharly
ccharly previously approved these changes Jun 27, 2024
digiwand
digiwand previously approved these changes Jun 27, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7c41c46]
Page Load Metrics (68 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682911014723
domContentLoaded98925189
load41201683617
domInteractive98925189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 64 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev merged commit d721e7f into develop Jul 2, 2024
73 checks passed
@montelaidev montelaidev deleted the fix/connected-sites branch July 2, 2024 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Accounts missing from dapp connection list and unable to disconnect
6 participants