Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swaps): fix to round gas values to integer #25488

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

nikoferro
Copy link
Member

@nikoferro nikoferro commented Jun 24, 2024

Description

This PR fixes rounding for max gas calculations, preventing the following issue while trying to perform a swap

image

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@nikoferro nikoferro self-assigned this Jun 24, 2024
@nikoferro nikoferro requested a review from a team as a code owner June 24, 2024 14:24
@nikoferro nikoferro marked this pull request as draft June 24, 2024 14:41
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.63%. Comparing base (18ebe12) to head (354a036).
Report is 3 commits behind head on develop.

Files Patch % Lines
ui/ducks/swaps/swaps.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25488      +/-   ##
===========================================
+ Coverage    69.62%   69.63%   +0.01%     
===========================================
  Files         1344     1344              
  Lines        47795    47783      -12     
  Branches     13190    13176      -14     
===========================================
- Hits         33273    33271       -2     
+ Misses       14522    14512      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@infiniteflower infiniteflower marked this pull request as ready for review June 24, 2024 19:16
@metamaskbot
Copy link
Collaborator

Builds ready [4b1d27a]
Page Load Metrics (49 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6713381136
domContentLoaded9421384
load4010049147
domInteractive9421384
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -279 Bytes (-0.00%)
  • common: 313 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [64f4685]
Page Load Metrics (56 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412189147
domContentLoaded9221231
load418856126
domInteractive9221231
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -279 Bytes (-0.00%)
  • common: 239 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [354a036]
Page Load Metrics (46 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62947674
domContentLoaded8211132
load38684684
domInteractive8211132
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -279 Bytes (-0.00%)
  • common: 239 Bytes (0.00%)

@infiniteflower infiniteflower merged commit 096d73f into develop Jun 24, 2024
73 checks passed
@infiniteflower infiniteflower deleted the fix/swaps-rounding branch June 24, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants